From 52629fbc4e90fdada5f004f8b80c6b38f66d1258 Mon Sep 17 00:00:00 2001 From: matt abrams <37156449+zuchka@users.noreply.github.com> Date: Thu, 3 Mar 2022 22:56:55 -1000 Subject: [PATCH] Postgres: Return tables with hyphenated schemes (#45754) * add basic test for buildSchemaConstraint function * wrap table schema in quote_ident function * fix type error in meta_query.test * swap test for inline comment * make comment more readable --- public/app/plugins/datasource/postgres/meta_query.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/public/app/plugins/datasource/postgres/meta_query.ts b/public/app/plugins/datasource/postgres/meta_query.ts index 4f915ef2fef..8bc0e3870c1 100644 --- a/public/app/plugins/datasource/postgres/meta_query.ts +++ b/public/app/plugins/datasource/postgres/meta_query.ts @@ -74,8 +74,9 @@ LIMIT 1 } buildSchemaConstraint() { + // quote_ident protects hyphenated schemes const query = ` -table_schema IN ( +quote_ident(table_schema) IN ( SELECT CASE WHEN trim(s[i]) = '"$user"' THEN user ELSE trim(s[i]) END FROM