Alerting: Query and expressions section simplification (#93022)

* Add mode switch in Query section

* Implement simple query mode : WIP

* fix logic switching mode

* move guard and get methodd to another folder

* Add more requiremts for being transformable from advanced to not advanced mode

* fix usig mode when it's not a grafana managed alert

* Show warning when switching to not advanced and its not possible to convert

* Add feature toggle alertingQueryAndExpressionsStepMode

* fix test

* add translations

* address PR feedback

* Use form context for sharing simplfied mode used, save in local storage and use the new fields in the api

* add check to valid reducer and threshold when switching to simplified mode

* Use only one expression list

* fix test

* move existing rule check outside storeInLocalStorageValues

* add id in InlineSwitch to handle onClick on label

* fix

* Fix default values when editing existing rule

* Update dto fields for the api request

* fix snapshot

* Fix recording rules to not show switch mode

* remove unnecessary Boolean conversion

* fix areQueriesTransformableToSimpleCondition

* update text

* pr review nit

* pr review part2
This commit is contained in:
Sonia Aguilar
2024-09-26 08:33:14 +02:00
committed by GitHub
parent c36f7aa92b
commit 536edee7bf
23 changed files with 904 additions and 192 deletions
+7
View File
@@ -1459,6 +1459,13 @@ var (
Owner: identityAccessTeam,
HideFromDocs: true,
},
{
Name: "alertingQueryAndExpressionsStepMode",
Description: "Enables step mode for alerting queries and expressions",
Stage: FeatureStageExperimental,
Owner: grafanaAlertingSquad,
FrontendOnly: true,
},
{
Name: "improvedExternalSessionHandling",
Description: "Enable improved support for external sessions in Grafana",
+1
View File
@@ -193,5 +193,6 @@ homeSetupGuide,experimental,@grafana/growth-and-onboarding,false,false,true
appPlatformAccessTokens,experimental,@grafana/identity-access-team,false,false,false
appSidecar,experimental,@grafana/explore-squad,false,false,false
groupAttributeSync,experimental,@grafana/identity-access-team,false,false,false
alertingQueryAndExpressionsStepMode,experimental,@grafana/alerting-squad,false,false,true
improvedExternalSessionHandling,experimental,@grafana/identity-access-team,false,false,false
useSessionStorageForRedirection,preview,@grafana/identity-access-team,false,false,false
1 Name Stage Owner requiresDevMode RequiresRestart FrontendOnly
193 appPlatformAccessTokens experimental @grafana/identity-access-team false false false
194 appSidecar experimental @grafana/explore-squad false false false
195 groupAttributeSync experimental @grafana/identity-access-team false false false
196 alertingQueryAndExpressionsStepMode experimental @grafana/alerting-squad false false true
197 improvedExternalSessionHandling experimental @grafana/identity-access-team false false false
198 useSessionStorageForRedirection preview @grafana/identity-access-team false false false
+4
View File
@@ -783,6 +783,10 @@ const (
// Enable the groupsync extension for managing Group Attribute Sync feature
FlagGroupAttributeSync = "groupAttributeSync"
// FlagAlertingQueryAndExpressionsStepMode
// Enables step mode for alerting queries and expressions
FlagAlertingQueryAndExpressionsStepMode = "alertingQueryAndExpressionsStepMode"
// FlagImprovedExternalSessionHandling
// Enable improved support for external sessions in Grafana
FlagImprovedExternalSessionHandling = "improvedExternalSessionHandling"
+13
View File
@@ -240,6 +240,19 @@
"hideFromAdminPage": true
}
},
{
"metadata": {
"name": "alertingQueryAndExpressionsStepMode",
"resourceVersion": "1725978395461",
"creationTimestamp": "2024-09-10T14:26:35Z"
},
"spec": {
"description": "Enables step mode for alerting queries and expressions",
"stage": "experimental",
"codeowner": "@grafana/alerting-squad",
"frontend": true
}
},
{
"metadata": {
"name": "alertingQueryOptimization",