LibraryPanels: Support CRUD via apiserver (#113035)

apps/dashboard/pkg/apis/dashboard/v0alpha1/librarypanel.go

@@ -0,0 +1,91 @@
+package v0alpha1
+
+import (
+	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+
+	data "github.com/grafana/grafana-plugin-sdk-go/experimental/apis/data/v0alpha1"
+	common "github.com/grafana/grafana/pkg/apimachinery/apis/common/v0alpha1"
+)
+
+// +k8s:deepcopy-gen=true
+// +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object
+type LibraryPanel struct {
+	metav1.TypeMeta `json:",inline"`
+	// Standard object's metadata
+	// More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#metadata
+	// +optional
+	metav1.ObjectMeta `json:"metadata,omitempty"`
+
+	// Panel properties
+	Spec LibraryPanelSpec `json:"spec"`
+
+	// Status will show errors
+	Status *LibraryPanelStatus `json:"status,omitempty"`
+}
+
+// +k8s:deepcopy-gen=true
+// +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object
+type LibraryPanelList struct {
+	metav1.TypeMeta `json:",inline"`
+	// +optional
+	metav1.ListMeta `json:"metadata,omitempty"`
+
+	Items []LibraryPanel `json:"items"`
+}
+
+// +k8s:deepcopy-gen=true
+type LibraryPanelSpec struct {
+	// The panel type
+	Type string `json:"type"`
+
+	// The panel type
+	PluginVersion string `json:"pluginVersion,omitempty"`
+
+	// The title of the library panel
+	Title string `json:"title,omitempty"`
+
+	// The title of the panel when displayed in the dashboard
+	PanelTitle string `json:"panelTitle,omitempty"`
+
+	// Library panel description
+	Description string `json:"description,omitempty"`
+
+	// The options schema depends on the panel type
+	Options common.Unstructured `json:"options"`
+
+	// The fieldConfig schema depends on the panel type
+	FieldConfig common.Unstructured `json:"fieldConfig"`
+
+	// The default datasource type
+	Datasource *data.DataSourceRef `json:"datasource,omitempty"`
+
+	// The grid position
+	GridPos GridPos `json:"gridPos,omitempty"`
+
+	// Whether the panel is transparent
+	Transparent bool `json:"transparent,omitempty"`
+
+	// The links for the panel
+	Links []common.Unstructured `json:"links,omitempty"`
+
+	// The datasource queries
+	// +listType=atomic
+	Targets []data.DataQuery `json:"targets,omitempty"`
+}
+
+// +k8s:deepcopy-gen=true
+type GridPos struct {
+	W int `json:"w"`
+	H int `json:"h"`
+	X int `json:"x"`
+	Y int `json:"y"`
+}
+
+// +k8s:deepcopy-gen=true
+type LibraryPanelStatus struct {
+	// Translation warnings (mostly things that were in SQL columns but not found in the saved body)
+	Warnings []string `json:"warnings,omitempty"`
+
+	// The properties previously stored in SQL that are not included in this model
+	Missing common.Unstructured `json:"missing,omitempty"`
+}

apps/dashboard/pkg/apis/dashboard/v0alpha1/types.go

@@ -1,95 +1,5 @@
 package v0alpha1
 
-import (
-	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
-
-	data "github.com/grafana/grafana-plugin-sdk-go/experimental/apis/data/v0alpha1"
-	common "github.com/grafana/grafana/pkg/apimachinery/apis/common/v0alpha1"
-)
-
-// +k8s:deepcopy-gen=true
-// +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object
-type LibraryPanel struct {
-	metav1.TypeMeta `json:",inline"`
-	// Standard object's metadata
-	// More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#metadata
-	// +optional
-	metav1.ObjectMeta `json:"metadata,omitempty"`
-
-	// Panel properties
-	Spec LibraryPanelSpec `json:"spec"`
-
-	// Status will show errors
-	Status *LibraryPanelStatus `json:"status,omitempty"`
-}
-
-// +k8s:deepcopy-gen=true
-// +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object
-type LibraryPanelList struct {
-	metav1.TypeMeta `json:",inline"`
-	// +optional
-	metav1.ListMeta `json:"metadata,omitempty"`
-
-	Items []LibraryPanel `json:"items"`
-}
-
-// +k8s:deepcopy-gen=true
-type LibraryPanelSpec struct {
-	// The panel type
-	Type string `json:"type"`
-
-	// The panel type
-	PluginVersion string `json:"pluginVersion,omitempty"`
-
-	// The title of the library panel
-	Title string `json:"title,omitempty"`
-
-	// The title of the panel when displayed in the dashboard
-	PanelTitle string `json:"panelTitle,omitempty"`
-
-	// Library panel description
-	Description string `json:"description,omitempty"`
-
-	// The options schema depends on the panel type
-	Options common.Unstructured `json:"options"`
-
-	// The fieldConfig schema depends on the panel type
-	FieldConfig common.Unstructured `json:"fieldConfig"`
-
-	// The default datasource type
-	Datasource *data.DataSourceRef `json:"datasource,omitempty"`
-
-	// The grid position
-	GridPos GridPos `json:"gridPos,omitempty"`
-
-	// Whether the panel is transparent
-	Transparent bool `json:"transparent,omitempty"`
-
-	// The links for the panel
-	Links []common.Unstructured `json:"links,omitempty"`
-
-	// The datasource queries
-	// +listType=set
-	Targets []data.DataQuery `json:"targets,omitempty"`
-}
-
-// +k8s:deepcopy-gen=true
-type GridPos struct {
-	W int `json:"w"`
-	H int `json:"h"`
-	X int `json:"x"`
-	Y int `json:"y"`
-}
-
-// +k8s:deepcopy-gen=true
-type LibraryPanelStatus struct {
-	// Translation warnings (mostly things that were in SQL columns but not found in the saved body)
-	Warnings []string `json:"warnings,omitempty"`
-
-	// The properties previously stored in SQL that are not included in this model
-	Missing common.Unstructured `json:"missing,omitempty"`
-}
-
 // This is like the legacy DTO where access and metadata are all returned in a single call
 // +k8s:deepcopy-gen=true
 // +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object

apps/dashboard/pkg/apis/dashboard/v0alpha1/zz_generated.openapi.go

@@ -882,7 +882,7 @@ func schema_pkg_apis_dashboard_v0alpha1_LibraryPanelSpec(ref common.ReferenceCal
 					"targets": {
 						VendorExtensible: spec.VendorExtensible{
 							Extensions: spec.Extensions{
-								"x-kubernetes-list-type": "set",
+								"x-kubernetes-list-type": "atomic",
 							},
 						},
 						SchemaProps: spec.SchemaProps{