Auth: Fix flaky tests that are mocking time.Now() from SSO Settings (#79581)

test time values using require.WithinDuration() instead of mocking time.Now()
This commit is contained in:
Mihai Doarna
2023-12-18 11:10:46 +02:00
committed by GitHub
parent 57ca8fa368
commit 53d209e6f1
2 changed files with 13 additions and 40 deletions
@@ -17,11 +17,6 @@ type SSOSettingsStore struct {
log log.Logger
}
var (
// timeNow makes it possible to test usage of time
timeNow = time.Now
)
func ProvideStore(sqlStore db.DB) *SSOSettingsStore {
return &SSOSettingsStore{
sqlStore: sqlStore,
@@ -87,7 +82,7 @@ func (s *SSOSettingsStore) Upsert(ctx context.Context, settings models.SSOSettin
return err
}
now := timeNow().UTC()
now := time.Now().UTC()
if found {
updated := &models.SSOSettings{
@@ -130,7 +125,7 @@ func (s *SSOSettingsStore) Delete(ctx context.Context, provider string) error {
return ssosettings.ErrNotFound
}
existing.Updated = timeNow().UTC()
existing.Updated = time.Now().UTC()
existing.IsDeleted = true
_, err = sess.ID(existing.ID).MustCols("updated", "is_deleted").Update(existing)