Chore: Refactor GoConvey in alerting tests (#40845)

pkg/services/alerting/eval_handler_test.go

@@ -7,7 +7,7 @@ import (
 	"github.com/grafana/grafana/pkg/plugins"
 	"github.com/grafana/grafana/pkg/services/validations"
 
-	. "github.com/smartystreets/goconvey/convey"
+	"github.com/stretchr/testify/require"
 )
 
 type conditionStub struct {
@@ -22,188 +22,186 @@ func (c *conditionStub) Eval(context *EvalContext, reqHandler plugins.DataReques
 }
 
 func TestAlertingEvaluationHandler(t *testing.T) {
-	Convey("Test alert evaluation handler", t, func() {
-		handler := NewEvalHandler(nil)
+	handler := NewEvalHandler(nil)
 
-		Convey("Show return triggered with single passing condition", func() {
-			context := NewEvalContext(context.TODO(), &Rule{
-				Conditions: []Condition{&conditionStub{
-					firing: true,
-				}},
-			}, &validations.OSSPluginRequestValidator{})
+	t.Run("Show return triggered with single passing condition", func(t *testing.T) {
+		context := NewEvalContext(context.TODO(), &Rule{
+			Conditions: []Condition{&conditionStub{
+				firing: true,
+			}},
+		}, &validations.OSSPluginRequestValidator{})
 
-			handler.Eval(context)
-			So(context.Firing, ShouldEqual, true)
-			So(context.ConditionEvals, ShouldEqual, "true = true")
-		})
+		handler.Eval(context)
+		require.Equal(t, true, context.Firing)
+		require.Equal(t, "true = true", context.ConditionEvals)
+	})
 
-		Convey("Show return triggered with single passing condition2", func() {
-			context := NewEvalContext(context.TODO(), &Rule{
-				Conditions: []Condition{&conditionStub{firing: true, operator: "and"}},
-			}, &validations.OSSPluginRequestValidator{})
+	t.Run("Show return triggered with single passing condition2", func(t *testing.T) {
+		context := NewEvalContext(context.TODO(), &Rule{
+			Conditions: []Condition{&conditionStub{firing: true, operator: "and"}},
+		}, &validations.OSSPluginRequestValidator{})
 
-			handler.Eval(context)
-			So(context.Firing, ShouldEqual, true)
-			So(context.ConditionEvals, ShouldEqual, "true = true")
-		})
+		handler.Eval(context)
+		require.Equal(t, true, context.Firing)
+		require.Equal(t, "true = true", context.ConditionEvals)
+	})
 
-		Convey("Show return false with not passing asdf", func() {
-			context := NewEvalContext(context.TODO(), &Rule{
-				Conditions: []Condition{
-					&conditionStub{firing: true, operator: "and", matches: []*EvalMatch{{}, {}}},
-					&conditionStub{firing: false, operator: "and"},
-				},
-			}, &validations.OSSPluginRequestValidator{})
+	t.Run("Show return false with not passing asdf", func(t *testing.T) {
+		context := NewEvalContext(context.TODO(), &Rule{
+			Conditions: []Condition{
+				&conditionStub{firing: true, operator: "and", matches: []*EvalMatch{{}, {}}},
+				&conditionStub{firing: false, operator: "and"},
+			},
+		}, &validations.OSSPluginRequestValidator{})
 
-			handler.Eval(context)
-			So(context.Firing, ShouldEqual, false)
-			So(context.ConditionEvals, ShouldEqual, "[true AND false] = false")
-		})
+		handler.Eval(context)
+		require.Equal(t, false, context.Firing)
+		require.Equal(t, "[true AND false] = false", context.ConditionEvals)
+	})
 
-		Convey("Show return true if any of the condition is passing with OR operator", func() {
-			context := NewEvalContext(context.TODO(), &Rule{
-				Conditions: []Condition{
-					&conditionStub{firing: true, operator: "and"},
-					&conditionStub{firing: false, operator: "or"},
-				},
-			}, &validations.OSSPluginRequestValidator{})
+	t.Run("Show return true if any of the condition is passing with OR operator", func(t *testing.T) {
+		context := NewEvalContext(context.TODO(), &Rule{
+			Conditions: []Condition{
+				&conditionStub{firing: true, operator: "and"},
+				&conditionStub{firing: false, operator: "or"},
+			},
+		}, &validations.OSSPluginRequestValidator{})
 
-			handler.Eval(context)
-			So(context.Firing, ShouldEqual, true)
-			So(context.ConditionEvals, ShouldEqual, "[true OR false] = true")
-		})
+		handler.Eval(context)
+		require.Equal(t, true, context.Firing)
+		require.Equal(t, "[true OR false] = true", context.ConditionEvals)
+	})
 
-		Convey("Show return false if any of the condition is failing with AND operator", func() {
-			context := NewEvalContext(context.TODO(), &Rule{
-				Conditions: []Condition{
-					&conditionStub{firing: true, operator: "and"},
-					&conditionStub{firing: false, operator: "and"},
-				},
-			}, &validations.OSSPluginRequestValidator{})
+	t.Run("Show return false if any of the condition is failing with AND operator", func(t *testing.T) {
+		context := NewEvalContext(context.TODO(), &Rule{
+			Conditions: []Condition{
+				&conditionStub{firing: true, operator: "and"},
+				&conditionStub{firing: false, operator: "and"},
+			},
+		}, &validations.OSSPluginRequestValidator{})
 
-			handler.Eval(context)
-			So(context.Firing, ShouldEqual, false)
-			So(context.ConditionEvals, ShouldEqual, "[true AND false] = false")
-		})
+		handler.Eval(context)
+		require.Equal(t, false, context.Firing)
+		require.Equal(t, "[true AND false] = false", context.ConditionEvals)
+	})
 
-		Convey("Show return true if one condition is failing with nested OR operator", func() {
-			context := NewEvalContext(context.TODO(), &Rule{
-				Conditions: []Condition{
-					&conditionStub{firing: true, operator: "and"},
-					&conditionStub{firing: true, operator: "and"},
-					&conditionStub{firing: false, operator: "or"},
-				},
-			}, &validations.OSSPluginRequestValidator{})
+	t.Run("Show return true if one condition is failing with nested OR operator", func(t *testing.T) {
+		context := NewEvalContext(context.TODO(), &Rule{
+			Conditions: []Condition{
+				&conditionStub{firing: true, operator: "and"},
+				&conditionStub{firing: true, operator: "and"},
+				&conditionStub{firing: false, operator: "or"},
+			},
+		}, &validations.OSSPluginRequestValidator{})
 
-			handler.Eval(context)
-			So(context.Firing, ShouldEqual, true)
-			So(context.ConditionEvals, ShouldEqual, "[[true AND true] OR false] = true")
-		})
+		handler.Eval(context)
+		require.Equal(t, true, context.Firing)
+		require.Equal(t, "[[true AND true] OR false] = true", context.ConditionEvals)
+	})
 
-		Convey("Show return false if one condition is passing with nested OR operator", func() {
-			context := NewEvalContext(context.TODO(), &Rule{
-				Conditions: []Condition{
-					&conditionStub{firing: true, operator: "and"},
-					&conditionStub{firing: false, operator: "and"},
-					&conditionStub{firing: false, operator: "or"},
-				},
-			}, &validations.OSSPluginRequestValidator{})
+	t.Run("Show return false if one condition is passing with nested OR operator", func(t *testing.T) {
+		context := NewEvalContext(context.TODO(), &Rule{
+			Conditions: []Condition{
+				&conditionStub{firing: true, operator: "and"},
+				&conditionStub{firing: false, operator: "and"},
+				&conditionStub{firing: false, operator: "or"},
+			},
+		}, &validations.OSSPluginRequestValidator{})
 
-			handler.Eval(context)
-			So(context.Firing, ShouldEqual, false)
-			So(context.ConditionEvals, ShouldEqual, "[[true AND false] OR false] = false")
-		})
+		handler.Eval(context)
+		require.Equal(t, false, context.Firing)
+		require.Equal(t, "[[true AND false] OR false] = false", context.ConditionEvals)
+	})
 
-		Convey("Show return false if a condition is failing with nested AND operator", func() {
-			context := NewEvalContext(context.TODO(), &Rule{
-				Conditions: []Condition{
-					&conditionStub{firing: true, operator: "and"},
-					&conditionStub{firing: false, operator: "and"},
-					&conditionStub{firing: true, operator: "and"},
-				},
-			}, &validations.OSSPluginRequestValidator{})
+	t.Run("Show return false if a condition is failing with nested AND operator", func(t *testing.T) {
+		context := NewEvalContext(context.TODO(), &Rule{
+			Conditions: []Condition{
+				&conditionStub{firing: true, operator: "and"},
+				&conditionStub{firing: false, operator: "and"},
+				&conditionStub{firing: true, operator: "and"},
+			},
+		}, &validations.OSSPluginRequestValidator{})
 
-			handler.Eval(context)
-			So(context.Firing, ShouldEqual, false)
-			So(context.ConditionEvals, ShouldEqual, "[[true AND false] AND true] = false")
-		})
+		handler.Eval(context)
+		require.Equal(t, false, context.Firing)
+		require.Equal(t, "[[true AND false] AND true] = false", context.ConditionEvals)
+	})
 
-		Convey("Show return true if a condition is passing with nested OR operator", func() {
-			context := NewEvalContext(context.TODO(), &Rule{
-				Conditions: []Condition{
-					&conditionStub{firing: true, operator: "and"},
-					&conditionStub{firing: false, operator: "or"},
-					&conditionStub{firing: true, operator: "or"},
-				},
-			}, &validations.OSSPluginRequestValidator{})
+	t.Run("Show return true if a condition is passing with nested OR operator", func(t *testing.T) {
+		context := NewEvalContext(context.TODO(), &Rule{
+			Conditions: []Condition{
+				&conditionStub{firing: true, operator: "and"},
+				&conditionStub{firing: false, operator: "or"},
+				&conditionStub{firing: true, operator: "or"},
+			},
+		}, &validations.OSSPluginRequestValidator{})
 
-			handler.Eval(context)
-			So(context.Firing, ShouldEqual, true)
-			So(context.ConditionEvals, ShouldEqual, "[[true OR false] OR true] = true")
-		})
+		handler.Eval(context)
+		require.Equal(t, true, context.Firing)
+		require.Equal(t, "[[true OR false] OR true] = true", context.ConditionEvals)
+	})
 
-		Convey("Should return false if no condition is firing using OR operator", func() {
-			context := NewEvalContext(context.TODO(), &Rule{
-				Conditions: []Condition{
-					&conditionStub{firing: false, operator: "or"},
-					&conditionStub{firing: false, operator: "or"},
-					&conditionStub{firing: false, operator: "or"},
-				},
-			}, &validations.OSSPluginRequestValidator{})
+	t.Run("Should return false if no condition is firing using OR operator", func(t *testing.T) {
+		context := NewEvalContext(context.TODO(), &Rule{
+			Conditions: []Condition{
+				&conditionStub{firing: false, operator: "or"},
+				&conditionStub{firing: false, operator: "or"},
+				&conditionStub{firing: false, operator: "or"},
+			},
+		}, &validations.OSSPluginRequestValidator{})
 
-			handler.Eval(context)
-			So(context.Firing, ShouldEqual, false)
-			So(context.ConditionEvals, ShouldEqual, "[[false OR false] OR false] = false")
-		})
+		handler.Eval(context)
+		require.Equal(t, false, context.Firing)
+		require.Equal(t, "[[false OR false] OR false] = false", context.ConditionEvals)
+	})
 
-		// FIXME: What should the actual test case name be here?
-		Convey("Should not return NoDataFound if all conditions have data and using OR", func() {
-			context := NewEvalContext(context.TODO(), &Rule{
-				Conditions: []Condition{
-					&conditionStub{operator: "or", noData: false},
-					&conditionStub{operator: "or", noData: false},
-					&conditionStub{operator: "or", noData: false},
-				},
-			}, &validations.OSSPluginRequestValidator{})
+	// FIXME: What should the actual test case name be here?
+	t.Run("Should not return NoDataFound if all conditions have data and using OR", func(t *testing.T) {
+		context := NewEvalContext(context.TODO(), &Rule{
+			Conditions: []Condition{
+				&conditionStub{operator: "or", noData: false},
+				&conditionStub{operator: "or", noData: false},
+				&conditionStub{operator: "or", noData: false},
+			},
+		}, &validations.OSSPluginRequestValidator{})
 
-			handler.Eval(context)
-			So(context.NoDataFound, ShouldBeFalse)
-		})
+		handler.Eval(context)
+		require.False(t, context.NoDataFound)
+	})
 
-		Convey("Should return NoDataFound if one condition has no data", func() {
-			context := NewEvalContext(context.TODO(), &Rule{
-				Conditions: []Condition{
-					&conditionStub{operator: "and", noData: true},
-				},
-			}, &validations.OSSPluginRequestValidator{})
+	t.Run("Should return NoDataFound if one condition has no data", func(t *testing.T) {
+		context := NewEvalContext(context.TODO(), &Rule{
+			Conditions: []Condition{
+				&conditionStub{operator: "and", noData: true},
+			},
+		}, &validations.OSSPluginRequestValidator{})
 
-			handler.Eval(context)
-			So(context.Firing, ShouldEqual, false)
-			So(context.NoDataFound, ShouldBeTrue)
-		})
+		handler.Eval(context)
+		require.Equal(t, false, context.Firing)
+		require.True(t, context.NoDataFound)
+	})
 
-		Convey("Should not return no data if at least one condition has no data and using AND", func() {
-			context := NewEvalContext(context.TODO(), &Rule{
-				Conditions: []Condition{
-					&conditionStub{operator: "and", noData: true},
-					&conditionStub{operator: "and", noData: false},
-				},
-			}, &validations.OSSPluginRequestValidator{})
+	t.Run("Should not return no data if at least one condition has no data and using AND", func(t *testing.T) {
+		context := NewEvalContext(context.TODO(), &Rule{
+			Conditions: []Condition{
+				&conditionStub{operator: "and", noData: true},
+				&conditionStub{operator: "and", noData: false},
+			},
+		}, &validations.OSSPluginRequestValidator{})
 
-			handler.Eval(context)
-			So(context.NoDataFound, ShouldBeFalse)
-		})
+		handler.Eval(context)
+		require.False(t, context.NoDataFound)
+	})
 
-		Convey("Should return no data if at least one condition has no data and using OR", func() {
-			context := NewEvalContext(context.TODO(), &Rule{
-				Conditions: []Condition{
-					&conditionStub{operator: "or", noData: true},
-					&conditionStub{operator: "or", noData: false},
-				},
-			}, &validations.OSSPluginRequestValidator{})
+	t.Run("Should return no data if at least one condition has no data and using OR", func(t *testing.T) {
+		context := NewEvalContext(context.TODO(), &Rule{
+			Conditions: []Condition{
+				&conditionStub{operator: "or", noData: true},
+				&conditionStub{operator: "or", noData: false},
+			},
+		}, &validations.OSSPluginRequestValidator{})
 
-			handler.Eval(context)
-			So(context.NoDataFound, ShouldBeTrue)
-		})
+		handler.Eval(context)
+		require.True(t, context.NoDataFound)
 	})
 }