From 5431c51490465cbed0f2f7267f484a1422ec39b1 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Ida=20=C5=A0tambuk?= <ida.stambuk@grafana.com>
Date: Tue, 20 Feb 2024 14:52:11 +0100
Subject: [PATCH] Cloudwatch: Add linting to restrict imports from core
 (#82538)

---------

Co-authored-by: Kevin Yu <kevinwcyu@users.noreply.github.com>
---
 .eslintrc                         | 4 +++-
 .golangci.toml                    | 2 ++
 pkg/tsdb/cloudwatch/cloudwatch.go | 2 +-
 3 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/.eslintrc b/.eslintrc
index e8cfd522609..76248968872 100644
--- a/.eslintrc
+++ b/.eslintrc
@@ -115,7 +115,9 @@
         "public/app/plugins/datasource/loki/*.{ts,tsx}",
         "public/app/plugins/datasource/loki/**/*.{ts,tsx}",
         "public/app/plugins/datasource/elasticsearch/*.{ts,tsx}",
-        "public/app/plugins/datasource/elasticsearch/**/*.{ts,tsx}"
+        "public/app/plugins/datasource/elasticsearch/**/*.{ts,tsx}",
+        "public/app/plugins/datasource/cloudwatch/*.{ts,tsx}",
+        "public/app/plugins/datasource/cloudwatch/**/*.{ts,tsx}"
       ],
       "settings": {
         "import/resolver": {
diff --git a/.golangci.toml b/.golangci.toml
index ef893498d77..b722776e84e 100644
--- a/.golangci.toml
+++ b/.golangci.toml
@@ -67,6 +67,8 @@ files = [
   "**/pkg/tsdb/parca/**/*",
   "**/pkg/tsdb/tempo/*",
   "**/pkg/tsdb/tempo/**/*",
+  "**/pkg/tsdb/cloudwatch/*",
+  "**/pkg/tsdb/cloudwatch/**/*",
 ]
 
 [linters-settings.gocritic]
diff --git a/pkg/tsdb/cloudwatch/cloudwatch.go b/pkg/tsdb/cloudwatch/cloudwatch.go
index dc975543237..735c65d2177 100644
--- a/pkg/tsdb/cloudwatch/cloudwatch.go
+++ b/pkg/tsdb/cloudwatch/cloudwatch.go
@@ -122,7 +122,7 @@ func NewInstanceSettings(httpClientProvider *httpclient.Provider) datasource.Ins
 	}
 }
 
-// cloudWatchExecutor executes CloudWatch requests.
+// cloudWatchExecutor executes CloudWatch requests
 type cloudWatchExecutor struct {
 	im          instancemgmt.InstanceManager
 	sessions    SessionCache