public/grafana
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Data source plugin: Improve error message when plugin has connection issues (#102625)

Browse Source 
* Improve data source error message when stackID

* Update comment

* Revert "Update comment"

This reverts commit 48922bc552.

* Revert "Improve data source error message when stackID"

This reverts commit 4bf0a2f7b7.

* Make public messagic configurable based on context

* Update, simplify

* Update

* Update getting stack

* Update pkg/plugins/errors.go

Co-authored-by: Andres Martinez Gotor <andres.martinez@grafana.com>

* Refactor test to test for when context has stack value

* Remove duplicated test

* Fix error checking logic

---------

Co-authored-by: Andres Martinez Gotor <andres.martinez@grafana.com>
This commit is contained in:
Ivana Huckova
2025-03-31 12:00:40 +02:00
committed by GitHub
co-authored by Andres Martinez Gotor
parent ffb6fb59a3
commit 54a51bd3e3
5 changed files with 83 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/plugins/manager/client/client_test.go
+2 -2
View File
@@ -50,8 +50,8 @@ func TestQueryData(t *testing.T) {
shouldPassThrough: false,
},
{
err: plugins.ErrPluginGrpcConnectionUnavailableBase.Errorf("unavailable"),
expectedError: plugins.ErrPluginGrpcConnectionUnavailableBase.Errorf("unavailable"),
err: plugins.ErrPluginGrpcConnectionUnavailableBaseFn(context.Background()).Errorf("unavailable"),
expectedError: plugins.ErrPluginGrpcConnectionUnavailableBaseFn(context.Background()).Errorf("unavailable"),
shouldPassThrough: true,
},
{