diff --git a/public/app/plugins/datasource/loki/components/LokiQueryEditor.tsx b/public/app/plugins/datasource/loki/components/LokiQueryEditor.tsx index b3b8563591f..85a9bd97902 100644 --- a/public/app/plugins/datasource/loki/components/LokiQueryEditor.tsx +++ b/public/app/plugins/datasource/loki/components/LokiQueryEditor.tsx @@ -165,7 +165,13 @@ export const LokiQueryEditor = React.memo((props) => { showExplain={explain} /> )} - + ); diff --git a/public/app/plugins/datasource/loki/components/LokiQueryEditorByApp.test.tsx b/public/app/plugins/datasource/loki/components/LokiQueryEditorByApp.test.tsx index 2f64b8faef9..c7530a2cddd 100644 --- a/public/app/plugins/datasource/loki/components/LokiQueryEditorByApp.test.tsx +++ b/public/app/plugins/datasource/loki/components/LokiQueryEditorByApp.test.tsx @@ -20,6 +20,7 @@ function setup(app: CoreApp): RenderResult { }, getQueryHints: () => [], getDataSamples: () => [], + maxLines: 20, } as unknown as LokiDatasource; return render( diff --git a/public/app/plugins/datasource/loki/querybuilder/components/LokiQueryBuilderOptions.test.tsx b/public/app/plugins/datasource/loki/querybuilder/components/LokiQueryBuilderOptions.test.tsx index 511bc2d7374..3f0c9e3eb59 100644 --- a/public/app/plugins/datasource/loki/querybuilder/components/LokiQueryBuilderOptions.test.tsx +++ b/public/app/plugins/datasource/loki/querybuilder/components/LokiQueryBuilderOptions.test.tsx @@ -46,6 +46,7 @@ function setup(queryOverrides: Partial = {}) { }, onRunQuery: jest.fn(), onChange: jest.fn(), + maxLines: 20, }; const { container } = render(); diff --git a/public/app/plugins/datasource/loki/querybuilder/components/LokiQueryBuilderOptions.tsx b/public/app/plugins/datasource/loki/querybuilder/components/LokiQueryBuilderOptions.tsx index 7e6e46596b5..cc46e9631ce 100644 --- a/public/app/plugins/datasource/loki/querybuilder/components/LokiQueryBuilderOptions.tsx +++ b/public/app/plugins/datasource/loki/querybuilder/components/LokiQueryBuilderOptions.tsx @@ -14,10 +14,11 @@ export interface Props { query: LokiQuery; onChange: (update: LokiQuery) => void; onRunQuery: () => void; + maxLines: number; app?: CoreApp; } -export const LokiQueryBuilderOptions = React.memo(({ app, query, onChange, onRunQuery }) => { +export const LokiQueryBuilderOptions = React.memo(({ app, query, onChange, onRunQuery, maxLines }) => { const onQueryTypeChange = (value: LokiQueryType) => { onChange({ ...query, queryType: value }); onRunQuery(); @@ -50,7 +51,7 @@ export const LokiQueryBuilderOptions = React.memo(({ app, query, onChange return ( - + (({ app, query, onChange (({ app, query, onChange ); }); -function getCollapsedInfo(query: LokiQuery, queryType: LokiQueryType, showMaxLines: boolean): string[] { +function getCollapsedInfo( + query: LokiQuery, + queryType: LokiQueryType, + showMaxLines: boolean, + maxLines: number +): string[] { const queryTypeLabel = queryTypeOptions.find((x) => x.value === queryType); const resolutionLabel = RESOLUTION_OPTIONS.find((x) => x.value === (query.resolution ?? 1)); @@ -109,8 +115,8 @@ function getCollapsedInfo(query: LokiQuery, queryType: LokiQueryType, showMaxLin items.push(`Type: ${queryTypeLabel?.label}`); - if (showMaxLines && query.maxLines) { - items.push(`Line limit: ${query.maxLines}`); + if (showMaxLines) { + items.push(`Line limit: ${query.maxLines ?? maxLines}`); } return items;