From 55fe1506ba7f3d8c4bc25884878c3a70d11ac094 Mon Sep 17 00:00:00 2001 From: Ryan McKinley Date: Wed, 31 Aug 2022 13:02:07 -0700 Subject: [PATCH] Plugins: unlock on plugin startup failure (#54555) --- pkg/plugins/manager/process/process.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/pkg/plugins/manager/process/process.go b/pkg/plugins/manager/process/process.go index 6ba85dbdb5f..e72b071123f 100644 --- a/pkg/plugins/manager/process/process.go +++ b/pkg/plugins/manager/process/process.go @@ -54,12 +54,13 @@ func (m *Manager) Start(ctx context.Context, pluginID string) error { m.log.Info("Plugin registered", "pluginID", p.ID) m.mu.Lock() + defer m.mu.Unlock() + if err := startPluginAndRestartKilledProcesses(ctx, p); err != nil { return err } p.Logger().Debug("Successfully started backend plugin process") - m.mu.Unlock() return nil }