From 56d35d32e2b003dbabc654bd1c59e43ebb77c56c Mon Sep 17 00:00:00 2001 From: Carl Bergquist Date: Thu, 29 Aug 2024 17:12:11 +0200 Subject: [PATCH] Scopes: increase limit on list calls to storage (#92687) scopes: increase limit on list calls to storage Signed-off-by: bergquist --- pkg/registry/apis/scope/find.go | 3 ++- pkg/registry/apis/scope/find_scope_dashboards.go | 4 +++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/pkg/registry/apis/scope/find.go b/pkg/registry/apis/scope/find.go index 4e22f3ccf39..43549a398a4 100644 --- a/pkg/registry/apis/scope/find.go +++ b/pkg/registry/apis/scope/find.go @@ -71,7 +71,7 @@ func (r *findREST) Connect(ctx context.Context, name string, opts runtime.Object results := &scope.FindScopeNodeChildrenResults{} raw, err := r.scopeNodeStorage.List(ctx, &internalversion.ListOptions{ - Limit: 1000, + Limit: 10000, }) if err != nil { @@ -80,6 +80,7 @@ func (r *findREST) Connect(ctx context.Context, name string, opts runtime.Object } all, ok := raw.(*scope.ScopeNodeList) + if !ok { responder.Error(fmt.Errorf("expected ScopeNodeList")) return diff --git a/pkg/registry/apis/scope/find_scope_dashboards.go b/pkg/registry/apis/scope/find_scope_dashboards.go index 6512ba8d5c7..81528b32b1f 100644 --- a/pkg/registry/apis/scope/find_scope_dashboards.go +++ b/pkg/registry/apis/scope/find_scope_dashboards.go @@ -64,7 +64,9 @@ func (f *findScopeDashboardsREST) Connect(ctx context.Context, name string, opts } return http.HandlerFunc(func(w http.ResponseWriter, req *http.Request) { - raw, err := f.scopeDashboardStorage.List(ctx, &internalversion.ListOptions{}) + raw, err := f.scopeDashboardStorage.List(ctx, &internalversion.ListOptions{ + Limit: 10000, + }) if err != nil { w.WriteHeader(500) return