From 57de2475b0f56d0a33abe64f8d2704ea83a16c7d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Torkel=20=C3=96degaard?= <torkel@grafana.com>
Date: Fri, 16 Nov 2018 15:09:14 +0100
Subject: [PATCH] various fixes to angular loading

---
 public/app/core/services/dynamic_directive_srv.ts        | 1 -
 .../app/features/dashboard/dashgrid/DashboardPanel.tsx   | 9 ---------
 .../app/features/dashboard/dashgrid/VisualizationTab.tsx | 4 ----
 public/app/features/dashboard/panel_model.ts             | 1 -
 4 files changed, 15 deletions(-)

diff --git a/public/app/core/services/dynamic_directive_srv.ts b/public/app/core/services/dynamic_directive_srv.ts
index 9b7ede59853..c27842ab54f 100644
--- a/public/app/core/services/dynamic_directive_srv.ts
+++ b/public/app/core/services/dynamic_directive_srv.ts
@@ -21,7 +21,6 @@ class DynamicDirectiveSrv {
     }
 
     if (!directiveInfo.fn.registered) {
-      console.log('register panel tab');
       coreModule.directive(attrs.$normalize(directiveInfo.name), directiveInfo.fn);
       directiveInfo.fn.registered = true;
     }
diff --git a/public/app/features/dashboard/dashgrid/DashboardPanel.tsx b/public/app/features/dashboard/dashgrid/DashboardPanel.tsx
index e909c2ec645..fee84fe95b2 100644
--- a/public/app/features/dashboard/dashgrid/DashboardPanel.tsx
+++ b/public/app/features/dashboard/dashgrid/DashboardPanel.tsx
@@ -59,10 +59,6 @@ export class DashboardPanel extends PureComponent<Props, State> {
     this.loadPlugin();
   };
 
-  onAngularPluginTypeChanged = () => {
-    this.loadPlugin();
-  };
-
   loadPlugin() {
     if (this.isSpecial()) {
       return;
@@ -94,9 +90,6 @@ export class DashboardPanel extends PureComponent<Props, State> {
   }
 
   componentDidUpdate() {
-    this.loadPlugin();
-
-    // handle angular plugin loading
     if (!this.element || this.state.angularPanel) {
       return;
     }
@@ -155,8 +148,6 @@ export class DashboardPanel extends PureComponent<Props, State> {
       return null;
     }
 
-    console.log('DashboardPanel.render()');
-
     const containerClass = this.props.isEditing ? 'panel-editor-container' : 'panel-height-helper';
     const panelWrapperClass = this.props.isEditing ? 'panel-editor-container__panel' : 'panel-height-helper';
 
diff --git a/public/app/features/dashboard/dashgrid/VisualizationTab.tsx b/public/app/features/dashboard/dashgrid/VisualizationTab.tsx
index 350ad619ff1..065a99ee60c 100644
--- a/public/app/features/dashboard/dashgrid/VisualizationTab.tsx
+++ b/public/app/features/dashboard/dashgrid/VisualizationTab.tsx
@@ -51,9 +51,6 @@ export class VisualizationTab extends PureComponent<Props> {
   }
 
   componentDidUpdate(prevProps: Props) {
-    console.log('VizTab component did update');
-
-    // if type changed
     if (this.props.plugin !== prevProps.plugin) {
       this.cleanUpAngularOptions();
     }
@@ -69,7 +66,6 @@ export class VisualizationTab extends PureComponent<Props> {
 
   loadAngularOptions() {
     const { angularPanel } = this.props;
-    console.log('loadAngularOptions angularPanel=' + angularPanel);
 
     const scope = angularPanel.getScope();
 
diff --git a/public/app/features/dashboard/panel_model.ts b/public/app/features/dashboard/panel_model.ts
index 14b252964b3..149d8cafa93 100644
--- a/public/app/features/dashboard/panel_model.ts
+++ b/public/app/features/dashboard/panel_model.ts
@@ -199,7 +199,6 @@ export class PanelModel {
         }
 
         delete this[key];
-        console.log('deleting ', key);
       }
     }
   }