public/grafana
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Dashboard Migrations: V7 - nav to timepicker (#112140)

Browse Source 
* migrate to v19

* migrate to v18

* Migration to be verified: v17 Convert minSpan to maxPerRow in panels

* Migration to be verified: 16 Grid layout migration

* Refactor v17 and v19 migrations to use shared helper functions

* Migration to be verified: 15 No-op migration for schema consistency

* Migration to be verified: 14 Shared crosshair to graph tooltip migration

* cleanup

* wip

* complete migration

* fix lint issues

* refactor and test with minimal graph config

* update tests

* migrate to v12

* extract defaults outside the func

* lint

* lint

* add missing showValues prop

* migrate to v11

* migrate to v10

* add test files

* update

* migrate to v9

* migrate to v8

* add context and fix latest version

* add context

* add context

* generate snapshots

* v13 should be no-op

* clean up

* fix tests

* add context

* snapshots

* generate snapshots

* update

* snapshots

* wip

* fix test

* remove nav when cleaning up defaults

* remove v28

* remove singlestat migraiton from frontend migrator because this is an automigration

* remove unused function

* Remove v24 table plugin logic

* cleanup

* remove plugin version for automigrate as it was used only in v24 and v28 that have been removed

* cleanup

* update snapshot

* update snapshot

* update snapshot

* lint

---------

Co-authored-by: Dominik Prokop <dominik.prokop@grafana.com>
This commit is contained in:
Haris Rozajac
2025-10-10 13:46:52 -06:00
committed by GitHub
co-authored by Dominik Prokop
parent b232a812ab
commit 58915bd384
9 changed files with 473 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files
apps/dashboard/pkg/migration/schemaversion/v7_test.go
+208
View File
@@ -0,0 +1,208 @@
package schemaversion_test
import (
"testing"
"github.com/grafana/grafana/apps/dashboard/pkg/migration/schemaversion"
)
func TestV7Migration(t *testing.T) {
testCases := []migrationTestCase{
{
name: "nav to timepicker conversion with query refId assignment",
input: map[string]interface{}{
"schemaVersion": 6,
"nav": []interface{}{
map[string]interface{}{
"enable": true,
"type": "timepicker",
"status": "Stable",
"time_options": []interface{}{"5m", "15m", "1h", "6h", "12h", "24h", "2d", "7d", "30d"},
"refresh_intervals": []interface{}{"5s", "10s", "30s", "1m", "5m", "15m", "30m", "1h", "2h", "1d"},
"now": true,
"collapse": false,
"notice": false,
},
},
"panels": []interface{}{
map[string]interface{}{
"targets": []interface{}{
map[string]interface{}{"expr": "up"},
map[string]interface{}{"expr": "cpu_usage", "refId": "B"},
},
},
},
},
expected: map[string]interface{}{
"schemaVersion": 7,
"nav": []interface{}{
map[string]interface{}{
"enable": true,
"type": "timepicker",
"status": "Stable",
"time_options": []interface{}{"5m", "15m", "1h", "6h", "12h", "24h", "2d", "7d", "30d"},
"refresh_intervals": []interface{}{"5s", "10s", "30s", "1m", "5m", "15m", "30m", "1h", "2h", "1d"},
"now": true,
"collapse": false,
"notice": false,
},
},
"timepicker": map[string]interface{}{
"enable": true,
"type": "timepicker",
"status": "Stable",
"time_options": []interface{}{"5m", "15m", "1h", "6h", "12h", "24h", "2d", "7d", "30d"},
"refresh_intervals": []interface{}{"5s", "10s", "30s", "1m", "5m", "15m", "30m", "1h", "2h", "1d"},
"now": true,
"collapse": false,
"notice": false,
},
"panels": []interface{}{
map[string]interface{}{
"targets": []interface{}{
map[string]interface{}{"expr": "up"},
map[string]interface{}{"expr": "cpu_usage", "refId": "B"},
},
},
},
},
},
{
name: "nav conversion without panels",
input: map[string]interface{}{
"schemaVersion": 6,
"nav": []interface{}{
map[string]interface{}{
"enable": true,
"type": "timepicker",
},
},
},
expected: map[string]interface{}{
"schemaVersion": 7,
"timepicker": map[string]interface{}{
"enable": true,
"type": "timepicker",
},
"nav": []interface{}{
map[string]interface{}{
"enable": true,
"type": "timepicker",
},
},
},
},
{
name: "empty nav array",
input: map[string]interface{}{
"schemaVersion": 6,
"nav": []interface{}{},
},
expected: map[string]interface{}{
"schemaVersion": 7,
"nav": []interface{}{},
},
},
{
name: "no nav property",
input: map[string]interface{}{
"schemaVersion": 6,
"title": "Test Dashboard",
},
expected: map[string]interface{}{
"schemaVersion": 7,
"title": "Test Dashboard",
},
},
{
name: "panels with nested panels",
input: map[string]interface{}{
"schemaVersion": 6,
"panels": []interface{}{
map[string]interface{}{
"type": "row",
"panels": []interface{}{
map[string]interface{}{
"targets": []interface{}{
map[string]interface{}{"expr": "memory_usage"},
},
},
},
},
},
},
expected: map[string]interface{}{
"schemaVersion": 7,
"panels": []interface{}{
map[string]interface{}{
"type": "row",
"panels": []interface{}{
map[string]interface{}{
"targets": []interface{}{
map[string]interface{}{"expr": "memory_usage"},
},
},
},
},
},
},
},
{
name: "multiple nav items - only first is used",
input: map[string]interface{}{
"schemaVersion": 6,
"nav": []interface{}{
map[string]interface{}{
"enable": true,
"type": "timepicker",
},
map[string]interface{}{
"enable": false,
"type": "other",
},
},
},
expected: map[string]interface{}{
"schemaVersion": 7,
"timepicker": map[string]interface{}{
"enable": true,
"type": "timepicker",
},
"nav": []interface{}{
map[string]interface{}{
"enable": true,
"type": "timepicker",
},
map[string]interface{}{
"enable": false,
"type": "other",
},
},
},
},
{
name: "invalid nav structure",
input: map[string]interface{}{
"schemaVersion": 6,
"nav": "invalid",
},
expected: map[string]interface{}{
"schemaVersion": 7,
"nav": "invalid",
},
},
{
name: "panels with invalid structure",
input: map[string]interface{}{
"schemaVersion": 6,
"panels": "invalid",
},
expected: map[string]interface{}{
"schemaVersion": 7,
"panels": "invalid",
},
},
}
runMigrationTests(t, testCases, schemaversion.V7)
}