From 58aa232a1b8d578cb0ef3e7cc52f4927ace8103c Mon Sep 17 00:00:00 2001 From: Giordano Ricci Date: Fri, 13 Jan 2023 00:51:14 +0000 Subject: [PATCH] Explore: Unsync time ranges when a pane is closed (#61369) (#61435) * Explore: Unsync time ranges when a pane is closed (#61369) * Explore: Unsync time ranges when a pane is closed * remove unintentional import (cherry picked from commit 1e33e56dbd6ff745b57c32e2111b19785626edf4) * remove unneeded property --- .../app/features/explore/state/main.test.ts | 25 ++++++++++++++++++- public/app/features/explore/state/main.ts | 1 + 2 files changed, 25 insertions(+), 1 deletion(-) diff --git a/public/app/features/explore/state/main.test.ts b/public/app/features/explore/state/main.test.ts index 3a5d5839784..048847154f5 100644 --- a/public/app/features/explore/state/main.test.ts +++ b/public/app/features/explore/state/main.test.ts @@ -141,9 +141,10 @@ describe('Explore reducer', () => { .thenStateShouldEqual({ left: rightItemMock, right: undefined, + syncedTimes: false, } as unknown as ExploreState); }); - it('should reset right pane when it is closed ', () => { + it('should reset right pane when it is closed', () => { const leftItemMock = { containerWidth: 100, } as unknown as ExploreItemState; @@ -164,6 +165,28 @@ describe('Explore reducer', () => { .thenStateShouldEqual({ left: leftItemMock, right: undefined, + syncedTimes: false, + } as unknown as ExploreState); + }); + + it('should unsync time ranges', () => { + const itemMock = { + containerWidth: 100, + } as unknown as ExploreItemState; + + const initialState = { + left: itemMock, + right: itemMock, + syncedTimes: true, + } as unknown as ExploreState; + + reducerTester() + .givenReducer(exploreReducer, initialState) + .whenActionIsDispatched(splitCloseAction({ itemId: ExploreId.right })) + .thenStateShouldEqual({ + left: itemMock, + right: undefined, + syncedTimes: false, } as unknown as ExploreState); }); }); diff --git a/public/app/features/explore/state/main.ts b/public/app/features/explore/state/main.ts index 3989cdbf359..5bed160cff9 100644 --- a/public/app/features/explore/state/main.ts +++ b/public/app/features/explore/state/main.ts @@ -179,6 +179,7 @@ export const exploreReducer = (state = initialExploreState, action: AnyAction): return { ...state, ...targetSplit, + syncedTimes: false, }; }