Chore: remove IsDisabled method for access control (#74340)

remove IsDisabled method for access control, clean up tests
This commit is contained in:
Ieva
2023-09-05 11:04:39 +01:00
committed by GitHub
parent 5ea16cb947
commit 58efa49933
14 changed files with 11 additions and 64 deletions
-10
View File
@@ -12,7 +12,6 @@ var _ accesscontrol.RoleRegistry = new(FakeService)
type FakeService struct {
ExpectedErr error
ExpectedDisabled bool
ExpectedCachedPermissions bool
ExpectedPermissions []accesscontrol.Permission
ExpectedFilteredUserPermissions []accesscontrol.Permission
@@ -49,10 +48,6 @@ func (f FakeService) RegisterFixedRoles(ctx context.Context) error {
return f.ExpectedErr
}
func (f FakeService) IsDisabled() bool {
return f.ExpectedDisabled
}
func (f FakeService) SaveExternalServiceRole(ctx context.Context, cmd accesscontrol.SaveExternalServiceRoleCommand) error {
return f.ExpectedErr
}
@@ -65,7 +60,6 @@ var _ accesscontrol.AccessControl = new(FakeAccessControl)
type FakeAccessControl struct {
ExpectedErr error
ExpectedDisabled bool
ExpectedEvaluate bool
}
@@ -76,10 +70,6 @@ func (f FakeAccessControl) Evaluate(ctx context.Context, user identity.Requester
func (f FakeAccessControl) RegisterScopeAttributeResolver(prefix string, resolver accesscontrol.ScopeAttributeResolver) {
}
func (f FakeAccessControl) IsDisabled() bool {
return f.ExpectedDisabled
}
type FakeStore struct {
ExpectedUserPermissions []accesscontrol.Permission
ExpectedUsersPermissions map[int64][]accesscontrol.Permission