Chore: Remove sqlQuerybuilderFunctionParameters feature toggle (#100809)

* chore: remove `sqlQuerybuilderFunctionParameters` ff

* Update packages/grafana-sql/src/components/visual-query-builder/SelectRow.tsx

Co-authored-by: ismail simsek <ismailsimsek09@gmail.com>

---------

Co-authored-by: ismail simsek <ismailsimsek09@gmail.com>

packages/grafana-sql/src/components/visual-query-builder/SelectRow.test.tsx

@@ -10,16 +10,6 @@ import { buildMockDB } from '../SqlComponents.testHelpers';
 
 import { SelectRow } from './SelectRow';
 
-// Mock featureToggle sqlQuerybuilderFunctionParameters
-jest.mock('@grafana/runtime', () => ({
-  ...jest.requireActual('@grafana/runtime'),
-  config: {
-    featureToggles: {
-      sqlQuerybuilderFunctionParameters: true,
-    },
-  },
-}));
-
 describe('SelectRow', () => {
   const query = Object.freeze<SQLQuery>({
     refId: 'A',

packages/grafana-sql/src/components/visual-query-builder/SelectRow.tsx

@@ -5,7 +5,6 @@ import { useCallback } from 'react';
 import { SelectableValue, toOption } from '@grafana/data';
 import { selectors } from '@grafana/e2e-selectors';
 import { EditorField } from '@grafana/plugin-ui';
-import { config } from '@grafana/runtime';
 import { Button, Select, Stack, useStyles2 } from '@grafana/ui';
 
 import { QueryEditorExpressionType, QueryEditorFunctionExpression } from '../../expressions';
@@ -13,7 +12,6 @@ import { DB, QueryFormat, SQLExpression, SQLQuery } from '../../types';
 import { createFunctionField } from '../../utils/sql.utils';
 import { useSqlChange } from '../../utils/useSqlChange';
 
-import { SelectColumn } from './SelectColumn';
 import { SelectFunctionParameters } from './SelectFunctionParameters';
 
 interface SelectRowProps {
@@ -35,27 +33,6 @@ export function SelectRow({ query, onQueryChange, db, columns }: SelectRowProps)
     timeSeriesAliasOpts.push({ label: 'value', value: 'value' });
   }
 
-  const onColumnChange = useCallback(
-    (item: QueryEditorFunctionExpression, index: number) => (column?: string) => {
-      let modifiedItem = { ...item };
-      if (!item.parameters?.length) {
-        modifiedItem.parameters = [{ type: QueryEditorExpressionType.FunctionParameter, name: column } as const];
-      } else {
-        modifiedItem.parameters = item.parameters.map((p) =>
-          p.type === QueryEditorExpressionType.FunctionParameter ? { ...p, name: column } : p
-        );
-      }
-
-      const newSql: SQLExpression = {
-        ...query.sql,
-        columns: query.sql?.columns?.map((c, i) => (i === index ? modifiedItem : c)),
-      };
-
-      onSqlChange(newSql);
-    },
-    [onSqlChange, query.sql]
-  );
-
   const onAggregationChange = useCallback(
     (item: QueryEditorFunctionExpression, index: number) => (aggregation: SelectableValue<string>) => {
       const newItem = {
@@ -134,18 +111,7 @@ export function SelectRow({ query, onQueryChange, db, columns }: SelectRowProps)
       {query.sql?.columns?.map((item, index) => (
         <div key={index}>
           <Stack gap={2} alignItems="end">
-            {!config.featureToggles.sqlQuerybuilderFunctionParameters && (
-              <SelectColumn
-                columns={columns}
-                onParameterChange={(v) => onColumnChange(item, index)(v)}
-                value={getColumnValue(item)}
-              />
-            )}
-            <EditorField
-              label={config.featureToggles.sqlQuerybuilderFunctionParameters ? 'Data operations' : 'Aggregation'}
-              optional
-              width={25}
-            >
+            <EditorField label="Data operations" optional width={25}>
               <Select
                 value={item.name ? toOption(item.name) : null}
                 inputId={`select-aggregation-${index}-${uniqueId()}`}
@@ -157,15 +123,14 @@ export function SelectRow({ query, onQueryChange, db, columns }: SelectRowProps)
                 onChange={onAggregationChange(item, index)}
               />
             </EditorField>
-            {config.featureToggles.sqlQuerybuilderFunctionParameters && (
-              <SelectFunctionParameters
-                currentColumnIndex={index}
-                columns={columns}
-                onSqlChange={onSqlChange}
-                query={query}
-                db={db}
-              />
-            )}
+
+            <SelectFunctionParameters
+              currentColumnIndex={index}
+              columns={columns}
+              onSqlChange={onSqlChange}
+              query={query}
+              db={db}
+            />
 
             <EditorField label="Alias" optional width={15}>
               <Select
@@ -213,11 +178,3 @@ const getStyles = () => {
     }),
   };
 };
-
-function getColumnValue({ parameters }: QueryEditorFunctionExpression): SelectableValue<string> | null {
-  const column = parameters?.find((p) => p.type === QueryEditorExpressionType.FunctionParameter);
-  if (column?.name) {
-    return toOption(column.name);
-  }
-  return null;
-}