From 5ad95a2952d623b251b1a62de021c33369b0f8ee Mon Sep 17 00:00:00 2001 From: Sven Grossmann Date: Mon, 9 Jan 2023 09:54:57 +0100 Subject: [PATCH] Loki: Fix tracking of `queries_with_changed_line_limit_count` (#60091) * change line limit tracking * updated test --- public/app/plugins/datasource/loki/module.test.ts | 2 +- public/app/plugins/datasource/loki/tracking.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/public/app/plugins/datasource/loki/module.test.ts b/public/app/plugins/datasource/loki/module.test.ts index a99b7fb1987..644bfd8818b 100644 --- a/public/app/plugins/datasource/loki/module.test.ts +++ b/public/app/plugins/datasource/loki/module.test.ts @@ -81,7 +81,7 @@ describe('queriesOnInitDashboard', () => { metric_queries_count: 3, queries_count: 5, queries_with_changed_legend_count: 3, - queries_with_changed_line_limit_count: 5, + queries_with_changed_line_limit_count: 2, queries_with_changed_resolution_count: 0, queries_with_template_variables_count: 2, range_queries_count: 4, diff --git a/public/app/plugins/datasource/loki/tracking.ts b/public/app/plugins/datasource/loki/tracking.ts index 37237178221..ae273601bd6 100644 --- a/public/app/plugins/datasource/loki/tracking.ts +++ b/public/app/plugins/datasource/loki/tracking.ts @@ -113,7 +113,7 @@ const isQueryWithChangedResolution = (query: LokiQuery): boolean => { }; const isQueryWithChangedLineLimit = (query: LokiQuery): boolean => { - return query.maxLines !== null || query.maxLines !== undefined; + return query.maxLines !== null && query.maxLines !== undefined; }; const isQueryWithChangedLegend = (query: LokiQuery): boolean => {