From 5c9aeaef41f5c35dbbb4daeee16d676a38bfa21f Mon Sep 17 00:00:00 2001 From: Alexander Weaver Date: Tue, 5 Sep 2023 10:43:13 -0500 Subject: [PATCH] Alerting: Do not exit if Redis ping fails when using redis-based Alertmanager clustering (#74144) Do not fail redis peer construction if ping fails --- pkg/services/ngalert/notifier/redis_peer.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkg/services/ngalert/notifier/redis_peer.go b/pkg/services/ngalert/notifier/redis_peer.go index bbed9276458..632019411be 100644 --- a/pkg/services/ngalert/notifier/redis_peer.go +++ b/pkg/services/ngalert/notifier/redis_peer.go @@ -2,7 +2,6 @@ package notifier import ( "context" - "fmt" "sort" "strconv" "sync" @@ -100,8 +99,9 @@ func newRedisPeer(cfg redisConfig, logger log.Logger, reg prometheus.Registerer, }) cmd := rdb.Ping(context.Background()) if cmd.Err() != nil { - return nil, fmt.Errorf("failed to ping redis: %w", cmd.Err()) + logger.Error("Failed to ping redis - redis-based alertmanager clustering may not be available", "err", cmd.Err()) } + // Make sure that the prefix uses a colon at the end as deliminator. if cfg.prefix != "" && cfg.prefix[len(cfg.prefix)-1] != ':' { cfg.prefix = cfg.prefix + ":"