Alerting: Don't save Alertmanager config on migration when 0 channels (#35119) (#35180)

* Alerting: Don't save Alertmanager config on migration when 0 channels

Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>

* Fix review

Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
(cherry picked from commit aa4c5bbfe4)

Co-authored-by: Ganesh Vernekar <15064823+codesome@users.noreply.github.com>

pkg/services/sqlstore/migrations/ualert/ualert.go

@@ -243,10 +243,28 @@ func (m *migration) Exec(sess *xorm.Session, mg *migrator.Migrator) error {
 		return err
 	}
 
+	if err := m.writeAlertmanagerConfig(&amConfig, allChannels); err != nil {
+		return err
+	}
+
+	if err := m.writeSilencesFile(); err != nil {
+		m.mg.Logger.Error("alert migration error: failed to write silence file", "err", err)
+	}
+
+	return nil
+}
+
+func (m *migration) writeAlertmanagerConfig(amConfig *PostableUserConfig, allChannels map[interface{}]*notificationChannel) error {
+	if len(allChannels) == 0 {
+		// No channels, hence don't require Alertmanager config.
+		m.mg.Logger.Info("alert migration: no notification channel found, skipping Alertmanager config")
+		return nil
+	}
+
 	if err := amConfig.EncryptSecureSettings(); err != nil {
 		return err
 	}
-	rawAmConfig, err := json.Marshal(&amConfig)
+	rawAmConfig, err := json.Marshal(amConfig)
 	if err != nil {
 		return err
 	}
@@ -262,10 +280,6 @@ func (m *migration) Exec(sess *xorm.Session, mg *migrator.Migrator) error {
 		return err
 	}
 
-	if err := m.writeSilencesFile(); err != nil {
-		m.mg.Logger.Error("alert migration error: failed to write silence file", "err", err)
-	}
-
 	return nil
 }