diff --git a/public/app/features/dashboard/dashgrid/DashboardGrid.tsx b/public/app/features/dashboard/dashgrid/DashboardGrid.tsx index 84db3a2cf99..6df8a8bc0aa 100644 --- a/public/app/features/dashboard/dashgrid/DashboardGrid.tsx +++ b/public/app/features/dashboard/dashgrid/DashboardGrid.tsx @@ -176,10 +176,9 @@ export class DashboardGrid extends React.Component { renderPanels() { const panelElements = []; - console.log('render panels'); for (const panel of this.props.dashboard.panels) { - const panelClasses = classNames({ panel: true, 'panel--fullscreen': panel.fullscreen }); + const panelClasses = classNames({ 'react-grid-item--fullscreen': panel.fullscreen }); panelElements.push(
{ } render() { - const { panel, dashboard } = this.props; + const { panel, dashboard, isFullscreen, isEditing } = this.props; const { plugin, angularPanel } = this.state; if (this.isSpecial()) { @@ -148,8 +149,12 @@ export class DashboardPanel extends PureComponent { return null; } - const containerClass = this.props.isEditing ? 'panel-editor-container' : 'panel-height-helper'; - const panelWrapperClass = this.props.isEditing ? 'panel-editor-container__panel' : 'panel-height-helper'; + const containerClass = classNames({ 'panel-editor-container': isEditing, 'panel-height-helper': !isEditing }); + const panelWrapperClass = classNames({ + 'panel-wrapper': true, + 'panel-wrapper--edit': isEditing, + 'panel-wrapper--view': isFullscreen && !isEditing, + }); return (
diff --git a/public/app/features/dashboard/dashgrid/PanelEditor.tsx b/public/app/features/dashboard/dashgrid/PanelEditor.tsx index 24e67538504..82fc849f81a 100644 --- a/public/app/features/dashboard/dashgrid/PanelEditor.tsx +++ b/public/app/features/dashboard/dashgrid/PanelEditor.tsx @@ -50,15 +50,6 @@ export class PanelEditor extends PureComponent { this.forceUpdate(); }; - onClose = () => { - store.dispatch( - updateLocation({ - query: { tab: null, fullscreen: null, edit: null }, - partial: true, - }) - ); - }; - render() { const { panel, dashboard, onTypeChanged, plugin, angularPanel } = this.props; const { location } = store.getState(); @@ -78,10 +69,6 @@ export class PanelEditor extends PureComponent { return ; })} - -
{activeTab === 'general' && } diff --git a/public/sass/components/_dashboard_grid.scss b/public/sass/components/_dashboard_grid.scss index 5f142dfd02f..1370bd96709 100644 --- a/public/sass/components/_dashboard_grid.scss +++ b/public/sass/components/_dashboard_grid.scss @@ -9,18 +9,14 @@ .react-grid-item { display: none !important; transition-property: none !important; - } - .panel--fullscreen { - display: block !important; - position: unset !important; - width: 100% !important; - height: 100% !important; - transform: translate(0px, 0px) !important; - } - - .panel { - margin: 0 !important; + &--fullscreen { + display: block !important; + position: unset !important; + width: 100% !important; + height: 100% !important; + transform: translate(0px, 0px) !important; + } } // Disable grid interaction indicators in fullscreen panels @@ -83,10 +79,10 @@ } // Disable animation on initial rendering and enable it when component has been mounted. -.react-grid-item.cssTransforms.panel { +.react-grid-item.cssTransforms { transition-property: none; } -.animated .react-grid-item.cssTransforms.panel { +.animated .react-grid-item.cssTransforms { transition-property: transform; } diff --git a/public/sass/components/_navbar.scss b/public/sass/components/_navbar.scss index dcf3b1f0aa9..84416c75c7d 100644 --- a/public/sass/components/_navbar.scss +++ b/public/sass/components/_navbar.scss @@ -50,6 +50,10 @@ .navbar-page-btn .fa-caret-down { display: none; } + + .navbar-buttons--close { + display: flex; + } } .navbar-page-btn { diff --git a/public/sass/components/_panel_editor.scss b/public/sass/components/_panel_editor.scss index 05608fd38ec..3e1b3755917 100644 --- a/public/sass/components/_panel_editor.scss +++ b/public/sass/components/_panel_editor.scss @@ -4,8 +4,19 @@ height: 100%; } -.panel-editor-container__panel { - flex: 1 1 0; +.panel-wrapper { + height: 100%; + + &--edit { + flex: 1 1 0; + height: unset; + } + + &--view { + flex: 1 1 0; + height: 80%; + padding: $dashboard-padding; + } } .panel-editor-container__editor {