Library panels: Move to integration tests (#108737)
This commit is contained in:
Stephanie Hingtgen
committed by
GitHub
GitHub
parent
f41570a6f7
commit
5ef744aa20
@@ -12,6 +12,7 @@ import (
|
||||
"k8s.io/apimachinery/pkg/runtime/schema"
|
||||
|
||||
"github.com/grafana/grafana/pkg/apiserver/rest"
|
||||
"github.com/grafana/grafana/pkg/services/org"
|
||||
"github.com/grafana/grafana/pkg/tests/apis"
|
||||
"github.com/grafana/grafana/pkg/tests/testinfra"
|
||||
)
|
||||
@@ -292,3 +293,145 @@ func deleteLibraryElement(t *testing.T, ctx TestContext, user apis.User, uid str
|
||||
|
||||
return nil
|
||||
}
|
||||
|
||||
func TestIntegrationLibraryPanelConnectionsWithFolderAccess(t *testing.T) {
|
||||
dualWriterModes := []rest.DualWriterMode{rest.Mode0, rest.Mode1, rest.Mode2, rest.Mode3, rest.Mode4, rest.Mode5}
|
||||
for _, dualWriterMode := range dualWriterModes {
|
||||
t.Run(fmt.Sprintf("DualWriterMode %d", dualWriterMode), func(t *testing.T) {
|
||||
helper := apis.NewK8sTestHelper(t, testinfra.GrafanaOpts{
|
||||
DisableAnonymous: true,
|
||||
EnableFeatureToggles: []string{
|
||||
"unifiedStorageSearch",
|
||||
"kubernetesLibraryPanels",
|
||||
"kubernetesClientDashboardsFolders",
|
||||
},
|
||||
})
|
||||
ctx := createTestContext(t, helper, helper.Org1, dualWriterMode)
|
||||
|
||||
accessibleFolder, err := createFolder(t, ctx.Helper, ctx.AdminUser, "AccessibleFolder")
|
||||
require.NoError(t, err)
|
||||
require.NotNil(t, accessibleFolder)
|
||||
|
||||
inaccessibleFolder, err := createFolder(t, ctx.Helper, ctx.AdminUser, "InAccessibleFolder")
|
||||
require.NoError(t, err)
|
||||
require.NotNil(t, inaccessibleFolder)
|
||||
|
||||
setResourceUserPermission(t, ctx, ctx.AdminUser, false, accessibleFolder.UID, addUserPermission(t, nil, ctx.ViewerUser, ResourcePermissionLevelView))
|
||||
setResourceUserPermission(t, ctx, ctx.AdminUser, false, inaccessibleFolder.UID, []ResourcePermissionSetting{})
|
||||
|
||||
libraryElement := map[string]interface{}{
|
||||
"kind": 1,
|
||||
"name": "Accessible Library Panel",
|
||||
"folderUid": accessibleFolder.UID,
|
||||
"model": map[string]interface{}{
|
||||
"type": "text",
|
||||
"title": "Accessible Library Panel",
|
||||
},
|
||||
}
|
||||
libraryElementURL := "/api/library-elements"
|
||||
libraryElementData, err := postHelper(t, &ctx, libraryElementURL, libraryElement, ctx.AdminUser)
|
||||
require.NoError(t, err)
|
||||
require.NotNil(t, libraryElementData)
|
||||
data := libraryElementData["result"].(map[string]interface{})
|
||||
uid := data["uid"].(string)
|
||||
require.NotEmpty(t, uid)
|
||||
|
||||
dashInGeneral := createDashboardObject(t, "Dashboard in General", "", 1)
|
||||
dashInGeneral.Object["spec"].(map[string]interface{})["panels"] = []interface{}{
|
||||
map[string]interface{}{
|
||||
"id": 1,
|
||||
"title": "Library Panel",
|
||||
"type": "library-panel-ref",
|
||||
"libraryPanel": map[string]interface{}{
|
||||
"uid": uid,
|
||||
"name": "Accessible Library Panel",
|
||||
},
|
||||
},
|
||||
}
|
||||
adminClient := getResourceClient(t, ctx.Helper, ctx.AdminUser, getDashboardGVR())
|
||||
createdDashInGeneral, err := adminClient.Resource.Create(context.Background(), dashInGeneral, v1.CreateOptions{})
|
||||
require.NoError(t, err)
|
||||
require.NotNil(t, createdDashInGeneral)
|
||||
|
||||
dashInAccessibleFolder := createDashboardObject(t, "Dashboard in Accessible Folder", accessibleFolder.UID, 1)
|
||||
dashInAccessibleFolder.Object["spec"].(map[string]interface{})["panels"] = []interface{}{
|
||||
map[string]interface{}{
|
||||
"id": 1,
|
||||
"title": "Library Panel",
|
||||
"type": "library-panel-ref",
|
||||
"libraryPanel": map[string]interface{}{
|
||||
"uid": uid,
|
||||
"name": "Accessible Library Panel",
|
||||
},
|
||||
},
|
||||
}
|
||||
createdDashInAccessible, err := adminClient.Resource.Create(context.Background(), dashInAccessibleFolder, v1.CreateOptions{})
|
||||
require.NoError(t, err)
|
||||
require.NotNil(t, createdDashInAccessible)
|
||||
|
||||
dashInInaccessibleFolder := createDashboardObject(t, "Dashboard in Inaccessible Folder", inaccessibleFolder.UID, 1)
|
||||
dashInInaccessibleFolder.Object["spec"].(map[string]interface{})["panels"] = []interface{}{
|
||||
map[string]interface{}{
|
||||
"id": 1,
|
||||
"title": "Library Panel",
|
||||
"type": "library-panel-ref",
|
||||
"libraryPanel": map[string]interface{}{
|
||||
"uid": uid,
|
||||
"name": "Accessible Library Panel",
|
||||
},
|
||||
},
|
||||
}
|
||||
createdDashInInaccessible, err := adminClient.Resource.Create(context.Background(), dashInInaccessibleFolder, v1.CreateOptions{})
|
||||
require.NoError(t, err)
|
||||
require.NotNil(t, createdDashInInaccessible)
|
||||
|
||||
connectionsURL := fmt.Sprintf("/api/library-elements/%s/connections", uid)
|
||||
connectionsData, err := getDashboardViaHTTP(t, &ctx, connectionsURL, ctx.AdminUser)
|
||||
require.NoError(t, err)
|
||||
require.NotNil(t, connectionsData)
|
||||
connections := connectionsData["result"].([]interface{})
|
||||
require.Len(t, connections, 3, "Admin should see all connections")
|
||||
connectionUIDs := make([]string, 0, len(connections))
|
||||
for _, conn := range connections {
|
||||
connMap := conn.(map[string]interface{})
|
||||
if connectionUID, ok := connMap["connectionUid"].(string); ok {
|
||||
connectionUIDs = append(connectionUIDs, connectionUID)
|
||||
}
|
||||
}
|
||||
generalDashUID := createdDashInGeneral.GetName()
|
||||
accessibleDashUID := createdDashInAccessible.GetName()
|
||||
inaccessibleDashUID := createdDashInInaccessible.GetName()
|
||||
require.Contains(t, connectionUIDs, generalDashUID, "Admin should see dashboard in general folder")
|
||||
require.Contains(t, connectionUIDs, accessibleDashUID, "Admin should see dashboard in accessible folder")
|
||||
require.Contains(t, connectionUIDs, inaccessibleDashUID, "Admin should see dashboard in inaccessible folder")
|
||||
|
||||
limitedUser := ctx.Helper.CreateUser("limited-user", "Org1", org.RoleViewer, nil)
|
||||
// can access accessibleFolder but not inaccessibleFolder
|
||||
setResourceUserPermission(t, ctx, ctx.AdminUser, false, accessibleFolder.UID, addUserPermission(t, nil, limitedUser, ResourcePermissionLevelView))
|
||||
setResourceUserPermission(t, ctx, ctx.AdminUser, false, inaccessibleFolder.UID, []ResourcePermissionSetting{})
|
||||
connectionsDataLimited, err := getDashboardViaHTTP(t, &ctx, connectionsURL, limitedUser)
|
||||
require.NoError(t, err)
|
||||
require.NotNil(t, connectionsDataLimited)
|
||||
connectionsLimited := connectionsDataLimited["result"].([]interface{})
|
||||
require.Len(t, connectionsLimited, 2, "Limited user should only see connections to accessible dashboards")
|
||||
|
||||
connectionUIDsLimited := make([]string, 0, len(connectionsLimited))
|
||||
for _, conn := range connectionsLimited {
|
||||
connMap := conn.(map[string]interface{})
|
||||
if connectionUID, ok := connMap["connectionUid"].(string); ok {
|
||||
connectionUIDsLimited = append(connectionUIDsLimited, connectionUID)
|
||||
}
|
||||
}
|
||||
require.Contains(t, connectionUIDsLimited, generalDashUID, "Limited user should see dashboard in general folder")
|
||||
require.Contains(t, connectionUIDsLimited, accessibleDashUID, "Limited user should see dashboard in accessible folder")
|
||||
require.NotContains(t, connectionUIDsLimited, inaccessibleDashUID, "Limited user should NOT see dashboard in inaccessible folder")
|
||||
|
||||
err = adminClient.Resource.Delete(context.Background(), createdDashInGeneral.GetName(), v1.DeleteOptions{})
|
||||
require.NoError(t, err)
|
||||
err = adminClient.Resource.Delete(context.Background(), createdDashInAccessible.GetName(), v1.DeleteOptions{})
|
||||
require.NoError(t, err)
|
||||
err = adminClient.Resource.Delete(context.Background(), createdDashInInaccessible.GetName(), v1.DeleteOptions{})
|
||||
require.NoError(t, err)
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user