diff --git a/pkg/tsdb/cloudwatch/accounts_test.go b/pkg/tsdb/cloudwatch/accounts_test.go index 67ac7587279..f788ae84897 100644 --- a/pkg/tsdb/cloudwatch/accounts_test.go +++ b/pkg/tsdb/cloudwatch/accounts_test.go @@ -7,6 +7,7 @@ import ( "testing" "github.com/grafana/grafana-aws-sdk/pkg/awsauth" + "github.com/grafana/grafana-aws-sdk/pkg/awsds" "github.com/grafana/grafana-plugin-sdk-go/backend/log" "github.com/grafana/grafana-plugin-sdk-go/backend/resource/httpadapter" "github.com/grafana/grafana/pkg/tsdb/cloudwatch/mocks" @@ -23,6 +24,9 @@ func newTestDatasource(opts ...func(*DataSource)) *DataSource { AWSConfigProvider: awsauth.NewFakeConfigProvider(false), logger: log.NewNullLogger(), tagValueCache: cache.New(0, 0), + Settings: models.CloudWatchSettings{ + AWSDatasourceSettings: awsds.AWSDatasourceSettings{Region: "us-east-1"}, + }, } ds.resourceHandler = httpadapter.New(ds.newResourceMux()) for _, opt := range opts { diff --git a/pkg/tsdb/cloudwatch/cloudwatch.go b/pkg/tsdb/cloudwatch/cloudwatch.go index 919b853887e..1015393477b 100644 --- a/pkg/tsdb/cloudwatch/cloudwatch.go +++ b/pkg/tsdb/cloudwatch/cloudwatch.go @@ -59,7 +59,7 @@ type DataSource struct { } func (ds *DataSource) newAWSConfig(ctx context.Context, region string) (aws.Config, error) { - if region == defaultRegion { + if region == defaultRegion || region == "" { if len(ds.Settings.Region) == 0 { return aws.Config{}, models.ErrMissingRegion } diff --git a/pkg/tsdb/cloudwatch/cloudwatch_integration_test.go b/pkg/tsdb/cloudwatch/cloudwatch_integration_test.go index 2278261468a..784f19cc401 100644 --- a/pkg/tsdb/cloudwatch/cloudwatch_integration_test.go +++ b/pkg/tsdb/cloudwatch/cloudwatch_integration_test.go @@ -269,6 +269,7 @@ func Test_CloudWatch_CallResource_Integration_Test(t *testing.T) { t.Run("Should error for any request when a default region is not selected", func(t *testing.T) { ds := newTestDatasource(func(ds *DataSource) { ds.Settings.GrafanaSettings.ListMetricsPageLimit = 1000 + ds.Settings.Region = "" }) req := &backend.CallResourceRequest{