From 42de27a2cb2cb99ccb08a73fd7cb76c1cffcfed2 Mon Sep 17 00:00:00 2001
From: utkarshcmu <utkarsh.cmu@gmail.com>
Date: Tue, 6 Dec 2016 03:54:44 -0800
Subject: [PATCH 1/4] Added help text for users

---
 public/app/features/panel/panel_menu.js | 1 +
 public/app/partials/panelgeneral.html   | 7 +++++++
 public/sass/components/_gf-form.scss    | 4 ++++
 3 files changed, 12 insertions(+)

diff --git a/public/app/features/panel/panel_menu.js b/public/app/features/panel/panel_menu.js
index bf420f7dc15..cb6f74fb89d 100644
--- a/public/app/features/panel/panel_menu.js
+++ b/public/app/features/panel/panel_menu.js
@@ -14,6 +14,7 @@ function (angular, $, _, Tether) {
           '<span class="panel-title drag-handle pointer">' +
             '<span class="icon-gf panel-alert-icon"></span>' +
             '<span class="panel-title-text drag-handle">{{ctrl.panel.title | interpolateTemplateVars:this}}</span>' +
+            '<span class="panel-help-text"><info-popover mode="bold">{{ctrl.panel.helpText}}</info-popover></span>' +
             '<span class="panel-links-btn"><i class="fa fa-external-link"></i></span>' +
             '<span class="panel-time-info" ng-show="ctrl.timeInfo"><i class="fa fa-clock-o"></i> {{ctrl.timeInfo}}</span>' +
           '</span>';
diff --git a/public/app/partials/panelgeneral.html b/public/app/partials/panelgeneral.html
index 99e56cc27de..077660302e9 100644
--- a/public/app/partials/panelgeneral.html
+++ b/public/app/partials/panelgeneral.html
@@ -27,6 +27,13 @@
 			</select>
 		</div>
 	</div>
+	<div class="gf-form-inline">
+   	<div class="gf-form max-width-42">
+   		<span class="gf-form-label width-8">Help Text</span>
+  		<input type="text" class="input-xxlarge tight-form-input" ng-model='ctrl.panel.helpText'></input>
+  		<input type="text" class="gf-form-input width-30" ng-model='ctrl.panel.helpText'></input>
+   	</div>
+   </div>
 </div>
 
 <panel-links-editor panel="ctrl.panel"></panel-links-editor>
diff --git a/public/sass/components/_gf-form.scss b/public/sass/components/_gf-form.scss
index 42498c47ac3..877276b674b 100644
--- a/public/sass/components/_gf-form.scss
+++ b/public/sass/components/_gf-form.scss
@@ -244,6 +244,10 @@ $gf-form-margin: 0.25rem;
   padding-left: $spacer;
   color: $text-color-weak;
 
+  &--bold {
+    color: $text-color-emphasis;
+  }
+
   &--right-absolute {
     position: absolute;
     right: $spacer;

From 034d84354ea474e472165e6880b8ee94c1e5c7a9 Mon Sep 17 00:00:00 2001
From: utkarshcmu <utkarsh.cmu@gmail.com>
Date: Tue, 6 Dec 2016 03:58:38 -0800
Subject: [PATCH 2/4] Fixed HelpText input box

---
 public/app/partials/panelgeneral.html | 1 -
 1 file changed, 1 deletion(-)

diff --git a/public/app/partials/panelgeneral.html b/public/app/partials/panelgeneral.html
index 077660302e9..d86ae54c0de 100644
--- a/public/app/partials/panelgeneral.html
+++ b/public/app/partials/panelgeneral.html
@@ -30,7 +30,6 @@
 	<div class="gf-form-inline">
    	<div class="gf-form max-width-42">
    		<span class="gf-form-label width-8">Help Text</span>
-  		<input type="text" class="input-xxlarge tight-form-input" ng-model='ctrl.panel.helpText'></input>
   		<input type="text" class="gf-form-input width-30" ng-model='ctrl.panel.helpText'></input>
    	</div>
    </div>

From 13f0b32a8ff43f394c270ed8f3afb9d30bf7ccda Mon Sep 17 00:00:00 2001
From: utkarshcmu <utkarsh.cmu@gmail.com>
Date: Tue, 6 Dec 2016 05:24:03 -0800
Subject: [PATCH 3/4] Added sanitizer to help text

---
 public/app/features/panel/panel_menu.js | 19 ++++++++++++++++++-
 1 file changed, 18 insertions(+), 1 deletion(-)

diff --git a/public/app/features/panel/panel_menu.js b/public/app/features/panel/panel_menu.js
index cb6f74fb89d..3524a0c019f 100644
--- a/public/app/features/panel/panel_menu.js
+++ b/public/app/features/panel/panel_menu.js
@@ -9,7 +9,7 @@ function (angular, $, _, Tether) {
 
   angular
     .module('grafana.directives')
-    .directive('panelMenu', function($compile, linkSrv) {
+    .directive('panelMenu', function($sanitize, $compile, linkSrv) {
       var linkTemplate =
           '<span class="panel-title drag-handle pointer">' +
             '<span class="icon-gf panel-alert-icon"></span>' +
@@ -19,6 +19,16 @@ function (angular, $, _, Tether) {
             '<span class="panel-time-info" ng-show="ctrl.timeInfo"><i class="fa fa-clock-o"></i> {{ctrl.timeInfo}}</span>' +
           '</span>';
 
+      function sanitizeString(str) {
+        try {
+          return $sanitize(str);
+        }
+        catch(err) {
+          console.log('Could not sanitize annotation string, html escaping instead');
+          return _.escape(str);
+        }
+      }
+
       function createExternalLinkMenu(ctrl) {
         var template = '<div class="panel-menu small">';
         template += '<div class="panel-menu-row">';
@@ -79,6 +89,7 @@ function (angular, $, _, Tether) {
           var $link = $(linkTemplate);
           var $panelLinksBtn = $link.find(".panel-links-btn");
           var $panelContainer = elem.parents(".panel-container");
+          var $panelHelpDrop = $link.find(".panel-help-text");
           var menuScope = null;
           var ctrl = $scope.ctrl;
           var timeout = null;
@@ -93,6 +104,12 @@ function (angular, $, _, Tether) {
             $panelLinksBtn.css({display: showIcon ? 'inline' : 'none'});
           });
 
+          $scope.$watch('ctrl.panel.helpText', function(helpText) {
+            helpText = sanitizeString(helpText);
+            var showIcon = (helpText ? helpText.length > 0 : false) && ctrl.panel.title !== '';
+            $panelHelpDrop.css({display: showIcon ? 'inline' : 'none'});
+          });
+
           function dismiss(time, force) {
             clearTimeout(timeout);
             timeout = null;

From 6b26a0f91d1a9c3ca7f9c8594b8f5b277b74825e Mon Sep 17 00:00:00 2001
From: utkarshcmu <utkarsh.cmu@gmail.com>
Date: Tue, 6 Dec 2016 05:53:33 -0800
Subject: [PATCH 4/4] Fixed hover position

---
 public/sass/components/_gf-form.scss | 1 +
 public/sass/pages/_dashboard.scss    | 5 +++++
 2 files changed, 6 insertions(+)

diff --git a/public/sass/components/_gf-form.scss b/public/sass/components/_gf-form.scss
index 877276b674b..004ab86fb76 100644
--- a/public/sass/components/_gf-form.scss
+++ b/public/sass/components/_gf-form.scss
@@ -246,6 +246,7 @@ $gf-form-margin: 0.25rem;
 
   &--bold {
     color: $text-color-emphasis;
+    padding-left: 0;
   }
 
   &--right-absolute {
diff --git a/public/sass/pages/_dashboard.scss b/public/sass/pages/_dashboard.scss
index 11933e0d76b..59875673982 100644
--- a/public/sass/pages/_dashboard.scss
+++ b/public/sass/pages/_dashboard.scss
@@ -73,6 +73,11 @@ div.flot-text {
   display: none;
 }
 
+.panel-help-text {
+  margin-left: 10px;
+  display: none; 
+}
+
 .panel-loading {
   position:absolute;
   top: -3px;