From 61484fa826926c1d378b853329f4d690e8e7a5bd Mon Sep 17 00:00:00 2001 From: Yuri Tseretyan Date: Mon, 1 May 2023 10:32:16 -0400 Subject: [PATCH] Alerting: Mention title of alert rule that caused migration to fail (#67451) * add debug log for migration of alert rules * add alert rule name and some information to conversion error --- pkg/services/sqlstore/migrations/ualert/ualert.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/pkg/services/sqlstore/migrations/ualert/ualert.go b/pkg/services/sqlstore/migrations/ualert/ualert.go index a7a4a83a759..009a078fb46 100644 --- a/pkg/services/sqlstore/migrations/ualert/ualert.go +++ b/pkg/services/sqlstore/migrations/ualert/ualert.go @@ -293,6 +293,7 @@ func (m *migration) Exec(sess *xorm.Session, mg *migrator.Migrator) error { for _, da := range dashAlerts { l := mg.Logger.New("ruleID", da.Id, "ruleName", da.Name, "dashboardUID", da.DashboardUID, "orgID", da.OrgId) + l.Debug("migrating alert rule to Unified Alerting") newCond, err := transConditions(*da.ParsedSettings, da.OrgId, dsIDMap) if err != nil { return err @@ -376,7 +377,7 @@ func (m *migration) Exec(sess *xorm.Session, mg *migrator.Migrator) error { } rule, err := m.makeAlertRule(*newCond, da, folder.Uid) if err != nil { - return err + return fmt.Errorf("failed to migrate alert rule '%s' [ID:%d, DashboardUID:%s, orgID:%d]: %w", da.Name, da.Id, da.DashboardUID, da.OrgId, err) } if _, ok := rulesPerOrg[rule.OrgID]; !ok {