diff --git a/packages/grafana-data/src/field/fieldDisplay.ts b/packages/grafana-data/src/field/fieldDisplay.ts index dd440110a6d..3d82f571926 100644 --- a/packages/grafana-data/src/field/fieldDisplay.ts +++ b/packages/grafana-data/src/field/fieldDisplay.ts @@ -196,48 +196,49 @@ export const getFieldDisplayValues = (options: GetFieldDisplayValuesOptions): Fi return sparkline.y.values.length - 1; case ReducerID.first: return 0; - case ReducerID.lastNotNull: { - for (let k = sparkline.y.values.length - 1; k >= 0; k--) { - const v = sparkline.y.values[k]; - if (v !== null && v !== undefined && !Number.isNaN(v)) { - return k; - } - } - return; - } - case ReducerID.firstNotNull: { - for (let k = 0; k < sparkline.y.values.length; k++) { - const v = sparkline.y.values[k]; - if (v !== null && v !== undefined && !Number.isNaN(v)) { - return k; - } - } - return; - } - case ReducerID.min: { - let minIdx = -1; - let prevMin = Infinity; - for (let k = 0; k < sparkline.y.values.length; k++) { - const v = sparkline.y.values[k]; - if (v !== null && v !== undefined && !Number.isNaN(v) && v < prevMin) { - prevMin = v; - minIdx = k; - } - } - return minIdx >= 0 ? minIdx : undefined; - } - case ReducerID.max: { - let maxIdx = -1; - let prevMax = -Infinity; - for (let k = 0; k < sparkline.y.values.length; k++) { - const v = sparkline.y.values[k]; - if (v !== null && v !== undefined && !Number.isNaN(v) && v > prevMax) { - prevMax = v; - maxIdx = k; - } - } - return maxIdx >= 0 ? maxIdx : undefined; - } + // TODO: #112977 enable more reducers for highlight index + // case ReducerID.lastNotNull: { + // for (let k = sparkline.y.values.length - 1; k >= 0; k--) { + // const v = sparkline.y.values[k]; + // if (v !== null && v !== undefined && !Number.isNaN(v)) { + // return k; + // } + // } + // return; + // } + // case ReducerID.firstNotNull: { + // for (let k = 0; k < sparkline.y.values.length; k++) { + // const v = sparkline.y.values[k]; + // if (v !== null && v !== undefined && !Number.isNaN(v)) { + // return k; + // } + // } + // return; + // } + // case ReducerID.min: { + // let minIdx = -1; + // let prevMin = Infinity; + // for (let k = 0; k < sparkline.y.values.length; k++) { + // const v = sparkline.y.values[k]; + // if (v !== null && v !== undefined && !Number.isNaN(v) && v < prevMin) { + // prevMin = v; + // minIdx = k; + // } + // } + // return minIdx >= 0 ? minIdx : undefined; + // } + // case ReducerID.max: { + // let maxIdx = -1; + // let prevMax = -Infinity; + // for (let k = 0; k < sparkline.y.values.length; k++) { + // const v = sparkline.y.values[k]; + // if (v !== null && v !== undefined && !Number.isNaN(v) && v > prevMax) { + // prevMax = v; + // maxIdx = k; + // } + // } + // return maxIdx >= 0 ? maxIdx : undefined; + // } default: return; } diff --git a/packages/grafana-ui/src/components/Sparkline/utils.ts b/packages/grafana-ui/src/components/Sparkline/utils.ts index ed0f665570c..6d5eafa9b76 100644 --- a/packages/grafana-ui/src/components/Sparkline/utils.ts +++ b/packages/grafana-ui/src/components/Sparkline/utils.ts @@ -99,6 +99,7 @@ export function getYRange(field: Field, alignedFrame: DataFrame): Range.MinMax { return [min, max]; } +// TODO: #112977 enable highlight index // const HIGHLIGHT_IDX_POINT_SIZE = 6; const defaultConfig: GraphFieldConfig = { @@ -192,6 +193,7 @@ export const prepareConfig = ( const colorMode = getFieldColorModeForField(field); const seriesColor = colorMode.getCalculator(field, theme)(0, 0); + // TODO: #112977 enable highlight index and adjust padding accordingly // const hasHighlightIndex = typeof sparkline.highlightIndex === 'number'; // if (hasHighlightIndex) { // builder.setPadding([rangePad, rangePad, rangePad, rangePad]); @@ -212,6 +214,7 @@ export const prepareConfig = ( lineWidth: customConfig.lineWidth, lineInterpolation: customConfig.lineInterpolation, showPoints: pointsMode, + // TODO: #112977 enable highlight index // pointSize: hasHighlightIndex ? HIGHLIGHT_IDX_POINT_SIZE : customConfig.pointSize, // pointsFilter: hasHighlightIndex ? [sparkline.highlightIndex!] : undefined, fillOpacity: customConfig.fillOpacity,