public/grafana
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

GoogleCloudMonitoring: Refactor types (#58644)

Browse Source
This commit is contained in:
Andres Martinez Gotor
2022-11-28 09:17:01 +01:00
committed by GitHub
parent 16af756d50
commit 64143ea7d0
8 changed files with 624 additions and 408 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/tsdb/cloudmonitoring/time_series_query_test.go
+25 -15
View File
@@ -21,8 +21,10 @@ func TestTimeSeriesQuery(t *testing.T) {
t.Run("and alias template is not specified", func(t *testing.T) {
res := &backend.DataResponse{}
query := &cloudMonitoringTimeSeriesQuery{
ProjectName: "test-proj",
Query: "test-query",
parameters: &timeSeriesQuery{
ProjectName: "test-proj",
Query: "test-query",
},
timeRange: backend.TimeRange{
From: fromStart,
To: fromStart.Add(34 * time.Minute),
@@ -37,9 +39,11 @@ func TestTimeSeriesQuery(t *testing.T) {
t.Run("and alias template is specified", func(t *testing.T) {
res := &backend.DataResponse{}
query := &cloudMonitoringTimeSeriesQuery{
ProjectName: "test-proj",
Query: "test-query",
AliasBy: "{{project}} - {{resource.label.zone}} - {{resource.label.instance_id}} - {{metric.label.response_code_class}}",
parameters: &timeSeriesQuery{
ProjectName: "test-proj",
Query: "test-query",
},
aliasBy: "{{project}} - {{resource.label.zone}} - {{resource.label.instance_id}} - {{metric.label.response_code_class}}",
timeRange: backend.TimeRange{
From: fromStart,
To: fromStart.Add(34 * time.Minute),
@@ -62,9 +66,11 @@ func TestTimeSeriesQuery(t *testing.T) {
res := &backend.DataResponse{}
query := &cloudMonitoringTimeSeriesQuery{
ProjectName: "test-proj",
Query: "test-query",
AliasBy: "{{project}} - {{resource.label.zone}} - {{resource.label.instance_id}} - {{metric.label.response_code_class}}",
parameters: &timeSeriesQuery{
ProjectName: "test-proj",
Query: "test-query",
},
aliasBy: "{{project}} - {{resource.label.zone}} - {{resource.label.instance_id}} - {{metric.label.response_code_class}}",
timeRange: backend.TimeRange{
From: fromStart,
To: fromStart.Add(34 * time.Minute),
@@ -85,8 +91,10 @@ func TestTimeSeriesQuery(t *testing.T) {
fromStart := time.Date(2018, 3, 15, 13, 0, 0, 0, time.UTC).In(time.Local)
res := &backend.DataResponse{}
query := &cloudMonitoringTimeSeriesQuery{
ProjectName: "test-proj",
Query: "test-query",
parameters: &timeSeriesQuery{
ProjectName: "test-proj",
Query: "test-query",
},
timeRange: backend.TimeRange{
From: fromStart,
To: fromStart.Add(34 * time.Minute),
@@ -109,13 +117,15 @@ func TestTimeSeriesQuery(t *testing.T) {
fromStart := time.Date(2018, 3, 15, 13, 0, 0, 0, time.UTC).In(time.Local)
res := &backend.DataResponse{}
query := &cloudMonitoringTimeSeriesQuery{
ProjectName: "test-proj",
Query: "test-query",
parameters: &timeSeriesQuery{
ProjectName: "test-proj",
Query: "test-query",
GraphPeriod: "60s",
},
timeRange: backend.TimeRange{
From: fromStart,
To: fromStart.Add(34 * time.Minute),
},
GraphPeriod: "60s",
}
err = query.parseResponse(res, data, "")
require.NoError(t, err)
@@ -125,12 +135,12 @@ func TestTimeSeriesQuery(t *testing.T) {
})
t.Run("appends graph_period to the query", func(t *testing.T) {
query := &cloudMonitoringTimeSeriesQuery{}
query := &cloudMonitoringTimeSeriesQuery{parameters: &timeSeriesQuery{}}
assert.Equal(t, query.appendGraphPeriod(&backend.QueryDataRequest{Queries: []backend.DataQuery{{}}}), " | graph_period 1ms")
})
t.Run("skips graph_period if disabled", func(t *testing.T) {
query := &cloudMonitoringTimeSeriesQuery{GraphPeriod: "disabled"}
query := &cloudMonitoringTimeSeriesQuery{parameters: &timeSeriesQuery{GraphPeriod: "disabled"}}
assert.Equal(t, query.appendGraphPeriod(&backend.QueryDataRequest{Queries: []backend.DataQuery{{}}}), "")
})
}