diff --git a/pkg/setting/setting.go b/pkg/setting/setting.go index b17699d519e..59f9e84dc25 100644 --- a/pkg/setting/setting.go +++ b/pkg/setting/setting.go @@ -1320,7 +1320,7 @@ func (cfg *Cfg) GetContentDeliveryURL(prefix string) string { } url.Path = path.Join(url.Path, prefix, preReleaseFolder, cfg.BuildVersion) - return url.String() + return url.String() + "/" } return "" diff --git a/pkg/setting/setting_test.go b/pkg/setting/setting_test.go index 762bfafa601..85e801eb605 100644 --- a/pkg/setting/setting_test.go +++ b/pkg/setting/setting_test.go @@ -398,8 +398,13 @@ func TestGetCDNPath(t *testing.T) { cfg.CDNRootURL, err = url.Parse("http://cdn.grafana.com") require.NoError(t, err) - require.Equal(t, "http://cdn.grafana.com/grafana-oss/v7.5.0-11124", cfg.GetContentDeliveryURL("grafana-oss")) - require.Equal(t, "http://cdn.grafana.com/grafana/v7.5.0-11124", cfg.GetContentDeliveryURL("grafana")) + require.Equal(t, "http://cdn.grafana.com/grafana-oss/v7.5.0-11124/", cfg.GetContentDeliveryURL("grafana-oss")) + require.Equal(t, "http://cdn.grafana.com/grafana/v7.5.0-11124/", cfg.GetContentDeliveryURL("grafana")) +} + +func TestGetContentDeliveryURLWhenNoCDNRootURLIsSet(t *testing.T) { + cfg := NewCfg() + require.Equal(t, "", cfg.GetContentDeliveryURL("grafana-oss")) } func TestGetCDNPathWithPreReleaseVersionAndSubPath(t *testing.T) { @@ -408,8 +413,8 @@ func TestGetCDNPathWithPreReleaseVersionAndSubPath(t *testing.T) { cfg.BuildVersion = "v7.5.0-11124pre" cfg.CDNRootURL, err = url.Parse("http://cdn.grafana.com/sub") require.NoError(t, err) - require.Equal(t, "http://cdn.grafana.com/sub/grafana-oss/pre-releases/v7.5.0-11124pre", cfg.GetContentDeliveryURL("grafana-oss")) - require.Equal(t, "http://cdn.grafana.com/sub/grafana/pre-releases/v7.5.0-11124pre", cfg.GetContentDeliveryURL("grafana")) + require.Equal(t, "http://cdn.grafana.com/sub/grafana-oss/pre-releases/v7.5.0-11124pre/", cfg.GetContentDeliveryURL("grafana-oss")) + require.Equal(t, "http://cdn.grafana.com/sub/grafana/pre-releases/v7.5.0-11124pre/", cfg.GetContentDeliveryURL("grafana")) } // Adding a case for this in case we switch to proper semver version strings @@ -419,6 +424,6 @@ func TestGetCDNPathWithAlphaVersion(t *testing.T) { cfg.BuildVersion = "v7.5.0-alpha.11124" cfg.CDNRootURL, err = url.Parse("http://cdn.grafana.com") require.NoError(t, err) - require.Equal(t, "http://cdn.grafana.com/grafana-oss/pre-releases/v7.5.0-alpha.11124", cfg.GetContentDeliveryURL("grafana-oss")) - require.Equal(t, "http://cdn.grafana.com/grafana/pre-releases/v7.5.0-alpha.11124", cfg.GetContentDeliveryURL("grafana")) + require.Equal(t, "http://cdn.grafana.com/grafana-oss/pre-releases/v7.5.0-alpha.11124/", cfg.GetContentDeliveryURL("grafana-oss")) + require.Equal(t, "http://cdn.grafana.com/grafana/pre-releases/v7.5.0-alpha.11124/", cfg.GetContentDeliveryURL("grafana")) } diff --git a/public/views/index-template.html b/public/views/index-template.html index 546bedfa026..15a98083c56 100644 --- a/public/views/index-template.html +++ b/public/views/index-template.html @@ -24,15 +24,15 @@ - - + + [[if .GoogleTagManagerId]] @@ -281,7 +282,7 @@ <% if (htmlWebpackPlugin.files.jsIntegrity) { %> <% } %>