From a1283212ed175bc02b9ccf67429b695562e1ba74 Mon Sep 17 00:00:00 2001 From: Mengyang Li Date: Sat, 23 Sep 2017 21:05:43 -0700 Subject: [PATCH 1/3] Use B/s instead Bps for Bytes per second Most places are using bps and B/s for bits and bytes, ref: https://en.wikipedia.org/wiki/Data_rate_units Bps (Bytes per second) isn't a really common used unit the in the wild. --- public/app/core/utils/kbn.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/public/app/core/utils/kbn.js b/public/app/core/utils/kbn.js index 38498ff1462..ea36ac61f14 100644 --- a/public/app/core/utils/kbn.js +++ b/public/app/core/utils/kbn.js @@ -419,7 +419,7 @@ function($, _, moment) { // Data Rate kbn.valueFormats.pps = kbn.formatBuilders.decimalSIPrefix('pps'); kbn.valueFormats.bps = kbn.formatBuilders.decimalSIPrefix('bps'); - kbn.valueFormats.Bps = kbn.formatBuilders.decimalSIPrefix('Bps'); + kbn.valueFormats.Bps = kbn.formatBuilders.decimalSIPrefix('B/s'); kbn.valueFormats.KBs = kbn.formatBuilders.decimalSIPrefix('Bs', 1); kbn.valueFormats.Kbits = kbn.formatBuilders.decimalSIPrefix('bps', 1); kbn.valueFormats.MBs = kbn.formatBuilders.decimalSIPrefix('Bs', 2); @@ -804,7 +804,7 @@ function($, _, moment) { submenu: [ {text: 'packets/sec', value: 'pps'}, {text: 'bits/sec', value: 'bps'}, - {text: 'bytes/sec', value: 'Bps'}, + {text: 'bytes/sec', value: 'B/s'}, {text: 'kilobits/sec', value: 'Kbits'}, {text: 'kilobytes/sec', value: 'KBs'}, {text: 'megabits/sec', value: 'Mbits'}, From 66c998e6e6dccae00bf2b3b61c7bcf759a5e0b45 Mon Sep 17 00:00:00 2001 From: Mengyang Li Date: Wed, 4 Oct 2017 14:37:05 -0700 Subject: [PATCH 2/3] Update kbn.js --- public/app/core/utils/kbn.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/public/app/core/utils/kbn.js b/public/app/core/utils/kbn.js index ea36ac61f14..962a8922685 100644 --- a/public/app/core/utils/kbn.js +++ b/public/app/core/utils/kbn.js @@ -419,7 +419,7 @@ function($, _, moment) { // Data Rate kbn.valueFormats.pps = kbn.formatBuilders.decimalSIPrefix('pps'); kbn.valueFormats.bps = kbn.formatBuilders.decimalSIPrefix('bps'); - kbn.valueFormats.Bps = kbn.formatBuilders.decimalSIPrefix('B/s'); + kbn.valueFormats.Bps = kbn.formatBuilders.decimalSIPrefix('Bps'); kbn.valueFormats.KBs = kbn.formatBuilders.decimalSIPrefix('Bs', 1); kbn.valueFormats.Kbits = kbn.formatBuilders.decimalSIPrefix('bps', 1); kbn.valueFormats.MBs = kbn.formatBuilders.decimalSIPrefix('Bs', 2); From 675e5ae17f25704ce721d979726a8d762a3501f2 Mon Sep 17 00:00:00 2001 From: Mengyang Li Date: Wed, 4 Oct 2017 17:37:19 -0700 Subject: [PATCH 3/3] Update kbn.js --- public/app/core/utils/kbn.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/public/app/core/utils/kbn.js b/public/app/core/utils/kbn.js index 962a8922685..41fea1c5024 100644 --- a/public/app/core/utils/kbn.js +++ b/public/app/core/utils/kbn.js @@ -419,7 +419,7 @@ function($, _, moment) { // Data Rate kbn.valueFormats.pps = kbn.formatBuilders.decimalSIPrefix('pps'); kbn.valueFormats.bps = kbn.formatBuilders.decimalSIPrefix('bps'); - kbn.valueFormats.Bps = kbn.formatBuilders.decimalSIPrefix('Bps'); + kbn.valueFormats.Bps = kbn.formatBuilders.decimalSIPrefix('B/s'); kbn.valueFormats.KBs = kbn.formatBuilders.decimalSIPrefix('Bs', 1); kbn.valueFormats.Kbits = kbn.formatBuilders.decimalSIPrefix('bps', 1); kbn.valueFormats.MBs = kbn.formatBuilders.decimalSIPrefix('Bs', 2); @@ -804,7 +804,7 @@ function($, _, moment) { submenu: [ {text: 'packets/sec', value: 'pps'}, {text: 'bits/sec', value: 'bps'}, - {text: 'bytes/sec', value: 'B/s'}, + {text: 'bytes/sec', value: 'Bps'}, {text: 'kilobits/sec', value: 'Kbits'}, {text: 'kilobytes/sec', value: 'KBs'}, {text: 'megabits/sec', value: 'Mbits'},