[v9.3.x] CI: Update golangci-lint to 1.51.2 for Go 1.20 compatibility (#65506)

[v9.3.x] Update golangci-lint to 1.51.2 for Go 1.20 compatibility

pkg/services/ngalert/provisioning/notification_policies.go

@@ -73,6 +73,7 @@ func (nps *NotificationPolicyService) UpdatePolicyTree(ctx context.Context, orgI
 		return err
 	}
 
+	//nolint:staticcheck // fixed in main
 	receivers, err := nps.receiversToMap(revision.cfg.AlertmanagerConfig.Receivers)
 	err = tree.ValidateReceivers(receivers)
 	if err != nil {

pkg/services/sqlstore/migrations/accesscontrol/dashboard_permissions.go

@@ -151,6 +151,7 @@ func (m dashboardPermissionsMigrator) migratePermissions(dashboards []dashboard,
 		return fmt.Errorf("failed to bulk-create roles: %w", err)
 	}
 
+	//nolint:gosimple // fixed in main
 	for i := range createdRoles {
 		allRoles = append(allRoles, createdRoles[i])
 	}

pkg/services/sqlstore/session_test.go

@@ -64,6 +64,9 @@ func TestRetryingOnFailures(t *testing.T) {
 	sess := store.GetSqlxSession()
 	rows, err := sess.Query(context.Background(), `SELECT "hello",2.3,4`)
 	require.NoError(t, err)
+	defer func() {
+		require.NoError(t, rows.Close())
+	}()
 	require.True(t, rows.Next()) // first row
 
 	str1 := ""

pkg/services/store/object/sqlstash/sql_storage_server.go

@@ -506,6 +506,7 @@ func (s *sqlObjectServer) fillCreationInfo(ctx context.Context, tx *session.Sess
 			err = rows.Scan(&createdAt, &createdBy)
 		}
 		if err == nil {
+			//nolint:sqlclosecheck
 			err = rows.Close()
 		}
 	}
@@ -526,6 +527,7 @@ func (s *sqlObjectServer) selectForUpdate(ctx context.Context, tx *session.Sessi
 		err = rows.Scan(&current.ETag, &current.Version, &current.UpdatedAt, &current.Size)
 	}
 	if err == nil {
+		//nolint:sqlclosecheck
 		err = rows.Close()
 	}
 	return current, err