Shared Azure middleware between Azure Monitor and Prometheus datasources (#46002)

* Scopes in Azure middleware

* Enable Azure middleware without feature flag

* Use common Azure middleware in Azure Monitor

* Apply feature flag to JsonData configuration of Azure auth

* Enforce feature flag in Prometheus datasource

* Prometheus provider tests

* Datasource service tests

* Fix http client provider tests

* Pass sdkhttpclient.Options by reference

* Add middleware to httpclient.Options

* Remove dependency on Grafana settings

* Unit-tests updated

* Fix ds_proxy_test

* Fix service_test

pkg/plugins/config.go

@@ -2,6 +2,7 @@ package plugins
 
 import (
 	"github.com/grafana/grafana/pkg/setting"
+	"github.com/grafana/grafana/pkg/tsdb/azuremonitor/azsettings"
 )
 
 type Cfg struct {
@@ -19,7 +20,7 @@ type Cfg struct {
 	AWSAssumeRoleEnabled    bool
 
 	// Azure Cloud settings
-	Azure setting.AzureSettings
+	Azure *azsettings.AzureSettings
 
 	BuildVersion string // TODO Remove
 }

pkg/plugins/manager/loader/initializer/initializer.go

@@ -84,14 +84,17 @@ func (i *Initializer) awsEnvVars() []string {
 
 func (i *Initializer) azureEnvVars() []string {
 	var variables []string
-	if i.cfg.Azure.Cloud != "" {
-		variables = append(variables, "AZURE_CLOUD="+i.cfg.Azure.Cloud)
-	}
-	if i.cfg.Azure.ManagedIdentityClientId != "" {
-		variables = append(variables, "AZURE_MANAGED_IDENTITY_CLIENT_ID="+i.cfg.Azure.ManagedIdentityClientId)
-	}
-	if i.cfg.Azure.ManagedIdentityEnabled {
-		variables = append(variables, "AZURE_MANAGED_IDENTITY_ENABLED=true")
+
+	if i.cfg.Azure != nil {
+		if i.cfg.Azure.Cloud != "" {
+			variables = append(variables, "AZURE_CLOUD="+i.cfg.Azure.Cloud)
+		}
+		if i.cfg.Azure.ManagedIdentityClientId != "" {
+			variables = append(variables, "AZURE_MANAGED_IDENTITY_CLIENT_ID="+i.cfg.Azure.ManagedIdentityClientId)
+		}
+		if i.cfg.Azure.ManagedIdentityEnabled {
+			variables = append(variables, "AZURE_MANAGED_IDENTITY_ENABLED=true")
+		}
 	}
 
 	return variables

pkg/plugins/manager/manager_integration_test.go

@@ -80,7 +80,7 @@ func TestPluginManager_int_init(t *testing.T) {
 	idb := influxdb.ProvideService(hcp)
 	lk := loki.ProvideService(hcp, tracer)
 	otsdb := opentsdb.ProvideService(hcp)
-	pr := prometheus.ProvideService(hcp, tracer)
+	pr := prometheus.ProvideService(hcp, cfg, features, tracer)
 	tmpo := tempo.ProvideService(hcp)
 	td := testdatasource.ProvideService(cfg, features)
 	pg := postgres.ProvideService(cfg)

pkg/plugins/manager/manager_test.go

@@ -8,6 +8,7 @@ import (
 	"time"
 
 	"github.com/grafana/grafana-plugin-sdk-go/backend"
+	"github.com/grafana/grafana/pkg/tsdb/azuremonitor/azsettings"
 
 	"github.com/grafana/grafana/pkg/infra/log"
 	"github.com/grafana/grafana/pkg/plugins"
@@ -574,9 +575,11 @@ func newScenario(t *testing.T, managed bool, fn func(t *testing.T, ctx *managerS
 	cfg.AWSAllowedAuthProviders = []string{"keys", "credentials"}
 	cfg.AWSAssumeRoleEnabled = true
 
-	cfg.Azure.ManagedIdentityEnabled = true
-	cfg.Azure.Cloud = "AzureCloud"
-	cfg.Azure.ManagedIdentityClientId = "client-id"
+	cfg.Azure = &azsettings.AzureSettings{
+		ManagedIdentityEnabled:  true,
+		Cloud:                   "AzureCloud",
+		ManagedIdentityClientId: "client-id",
+	}
 
 	loader := &fakeLoader{}
 	manager := New(cfg, nil, loader)