FeatureFlags: Revert managing feature flags outside of settings.Cfg (#44382)

* Revert "FeatureToggles: register all enterprise feature toggles (#44336)"

This reverts commit f53b3fb007.

* Revert "FeatureFlags: manage feature flags outside of settings.Cfg (#43692)"

This reverts commit f94c0decbd.
This commit is contained in:
Agnès Toulet
2022-01-24 16:08:05 +01:00
committed by GitHub
parent 29268483c2
commit 65bdb3a899
66 changed files with 249 additions and 1324 deletions
+19 -1
View File
@@ -14,6 +14,7 @@ func TestFeatureToggles(t *testing.T) {
conf map[string]string
err error
expectedToggles map[string]bool
defaultToggles map[string]bool
}{
{
name: "can parse feature toggles passed in the `enable` array",
@@ -57,6 +58,18 @@ func TestFeatureToggles(t *testing.T) {
expectedToggles: map[string]bool{},
err: strconv.ErrSyntax,
},
{
name: "should override default feature toggles",
defaultToggles: map[string]bool{
"feature1": true,
},
conf: map[string]string{
"feature1": "false",
},
expectedToggles: map[string]bool{
"feature1": false,
},
},
}
for _, tc := range testCases {
@@ -68,7 +81,12 @@ func TestFeatureToggles(t *testing.T) {
require.ErrorIs(t, err, nil)
}
featureToggles, err := ReadFeatureTogglesFromInitFile(toggles)
dt := map[string]bool{}
if len(tc.defaultToggles) > 0 {
dt = tc.defaultToggles
}
featureToggles, err := overrideDefaultWithConfiguration(f, dt)
require.ErrorIs(t, err, tc.err)
if err == nil {