FeatureFlags: Revert managing feature flags outside of settings.Cfg (#44382)
* Revert "FeatureToggles: register all enterprise feature toggles (#44336)" This reverts commitf53b3fb007. * Revert "FeatureFlags: manage feature flags outside of settings.Cfg (#43692)" This reverts commitf94c0decbd.
This commit is contained in:
@@ -14,6 +14,7 @@ func TestFeatureToggles(t *testing.T) {
|
||||
conf map[string]string
|
||||
err error
|
||||
expectedToggles map[string]bool
|
||||
defaultToggles map[string]bool
|
||||
}{
|
||||
{
|
||||
name: "can parse feature toggles passed in the `enable` array",
|
||||
@@ -57,6 +58,18 @@ func TestFeatureToggles(t *testing.T) {
|
||||
expectedToggles: map[string]bool{},
|
||||
err: strconv.ErrSyntax,
|
||||
},
|
||||
{
|
||||
name: "should override default feature toggles",
|
||||
defaultToggles: map[string]bool{
|
||||
"feature1": true,
|
||||
},
|
||||
conf: map[string]string{
|
||||
"feature1": "false",
|
||||
},
|
||||
expectedToggles: map[string]bool{
|
||||
"feature1": false,
|
||||
},
|
||||
},
|
||||
}
|
||||
|
||||
for _, tc := range testCases {
|
||||
@@ -68,7 +81,12 @@ func TestFeatureToggles(t *testing.T) {
|
||||
require.ErrorIs(t, err, nil)
|
||||
}
|
||||
|
||||
featureToggles, err := ReadFeatureTogglesFromInitFile(toggles)
|
||||
dt := map[string]bool{}
|
||||
if len(tc.defaultToggles) > 0 {
|
||||
dt = tc.defaultToggles
|
||||
}
|
||||
|
||||
featureToggles, err := overrideDefaultWithConfiguration(f, dt)
|
||||
require.ErrorIs(t, err, tc.err)
|
||||
|
||||
if err == nil {
|
||||
|
||||
Reference in New Issue
Block a user