From 66b4a9e6a1b848829c2bc02600929ceaac6fab5d Mon Sep 17 00:00:00 2001 From: Ivana Huckova <30407135+ivanahuckova@users.noreply.github.com> Date: Thu, 30 Jun 2022 16:02:27 +0200 Subject: [PATCH] Loki: Remove unused prop from query builder (#51504) --- .betterer.results | 10 +++++----- .../loki/querybuilder/components/LokiQueryBuilder.tsx | 3 +-- .../loki/querybuilder/components/NestedQuery.tsx | 1 - .../prometheus/querybuilder/components/NestedQuery.tsx | 1 - .../querybuilder/components/PromQueryBuilder.tsx | 1 - 5 files changed, 6 insertions(+), 10 deletions(-) diff --git a/.betterer.results b/.betterer.results index 02dd9926785..5b5eea8023a 100644 --- a/.betterer.results +++ b/.betterer.results @@ -9320,9 +9320,9 @@ exports[`better eslint`] = { [43, 18, 3, "Unexpected any. Specify a different type.", "193409811"], [44, 9, 3, "Unexpected any. Specify a different type.", "193409811"] ], - "public/app/plugins/datasource/loki/querybuilder/components/LokiQueryBuilder.tsx:1944597108": [ - [34, 86, 3, "Unexpected any. Specify a different type.", "193409811"], - [98, 22, 27, "Do not use any type assertions.", "2133479311"] + "public/app/plugins/datasource/loki/querybuilder/components/LokiQueryBuilder.tsx:2376559976": [ + [33, 86, 3, "Unexpected any. Specify a different type.", "193409811"], + [97, 22, 27, "Do not use any type assertions.", "2133479311"] ], "public/app/plugins/datasource/loki/querybuilder/components/LokiQueryBuilderContainer.test.tsx:3009382449": [ [25, 16, 9, "Do not use any type assertions.", "3692209159"], @@ -10320,8 +10320,8 @@ exports[`better eslint`] = { [193, 18, 3, "Unexpected any. Specify a different type.", "193409811"], [194, 9, 3, "Unexpected any. Specify a different type.", "193409811"] ], - "public/app/plugins/datasource/prometheus/querybuilder/components/PromQueryBuilder.tsx:4173778590": [ - [106, 22, 27, "Do not use any type assertions.", "2133479311"] + "public/app/plugins/datasource/prometheus/querybuilder/components/PromQueryBuilder.tsx:3149551043": [ + [105, 22, 27, "Do not use any type assertions.", "2133479311"] ], "public/app/plugins/datasource/prometheus/querybuilder/components/PromQueryBuilderContainer.test.tsx:3545369509": [ [36, 27, 68, "Do not use any type assertions.", "1641181778"], diff --git a/public/app/plugins/datasource/loki/querybuilder/components/LokiQueryBuilder.tsx b/public/app/plugins/datasource/loki/querybuilder/components/LokiQueryBuilder.tsx index 13fff38993b..ed8f544e0b5 100644 --- a/public/app/plugins/datasource/loki/querybuilder/components/LokiQueryBuilder.tsx +++ b/public/app/plugins/datasource/loki/querybuilder/components/LokiQueryBuilder.tsx @@ -19,10 +19,9 @@ export interface Props { datasource: LokiDatasource; onChange: (update: LokiVisualQuery) => void; onRunQuery: () => void; - nested?: boolean; } -export const LokiQueryBuilder = React.memo(({ datasource, query, nested, onChange, onRunQuery }) => { +export const LokiQueryBuilder = React.memo(({ datasource, query, onChange, onRunQuery }) => { const onChangeLabels = (labels: QueryBuilderLabelFilter[]) => { onChange({ ...query, labels }); }; diff --git a/public/app/plugins/datasource/loki/querybuilder/components/NestedQuery.tsx b/public/app/plugins/datasource/loki/querybuilder/components/NestedQuery.tsx index fbd4ed2074f..c4431109680 100644 --- a/public/app/plugins/datasource/loki/querybuilder/components/NestedQuery.tsx +++ b/public/app/plugins/datasource/loki/querybuilder/components/NestedQuery.tsx @@ -76,7 +76,6 @@ export const NestedQuery = React.memo(({ nestedQuery, index, datasource, { onChange(index, { ...nestedQuery, query: update }); diff --git a/public/app/plugins/datasource/prometheus/querybuilder/components/NestedQuery.tsx b/public/app/plugins/datasource/prometheus/querybuilder/components/NestedQuery.tsx index 2bf6c16c66c..8656301af53 100644 --- a/public/app/plugins/datasource/prometheus/querybuilder/components/NestedQuery.tsx +++ b/public/app/plugins/datasource/prometheus/querybuilder/components/NestedQuery.tsx @@ -76,7 +76,6 @@ export const NestedQuery = React.memo(({ nestedQuery, index, datasource, { onChange(index, { ...nestedQuery, query: update }); diff --git a/public/app/plugins/datasource/prometheus/querybuilder/components/PromQueryBuilder.tsx b/public/app/plugins/datasource/prometheus/querybuilder/components/PromQueryBuilder.tsx index 3fba042d304..078f02d0b69 100644 --- a/public/app/plugins/datasource/prometheus/querybuilder/components/PromQueryBuilder.tsx +++ b/public/app/plugins/datasource/prometheus/querybuilder/components/PromQueryBuilder.tsx @@ -21,7 +21,6 @@ export interface Props { datasource: PrometheusDatasource; onChange: (update: PromVisualQuery) => void; onRunQuery: () => void; - nested?: boolean; data?: PanelData; }