diff --git a/.betterer.results b/.betterer.results index 3cfced5f9d1..0ac51d62848 100644 --- a/.betterer.results +++ b/.betterer.results @@ -653,9 +653,6 @@ exports[`better eslint`] = { [0, 0, 0, "Unexpected any. Specify a different type.", "2"], [0, 0, 0, "Unexpected any. Specify a different type.", "3"] ], - "packages/grafana-ui/src/components/PanelChrome/LoadingIndicator.tsx:5381": [ - [0, 0, 0, "Use data-testid for E2E selectors instead of aria-label", "0"] - ], "packages/grafana-ui/src/components/PanelChrome/PanelContext.ts:5381": [ [0, 0, 0, "Unexpected any. Specify a different type.", "0"], [0, 0, 0, "Unexpected any. Specify a different type.", "1"] @@ -4612,9 +4609,8 @@ exports[`better eslint`] = { [0, 0, 0, "Unexpected any. Specify a different type.", "12"] ], "public/app/features/variables/pickers/shared/VariableLink.tsx:5381": [ - [0, 0, 0, "Use data-testid for E2E selectors instead of aria-label", "0"], - [0, 0, 0, "Styles should be written using objects.", "1"], - [0, 0, 0, "Styles should be written using objects.", "2"] + [0, 0, 0, "Styles should be written using objects.", "0"], + [0, 0, 0, "Styles should be written using objects.", "1"] ], "public/app/features/variables/pickers/shared/VariableOptions.tsx:5381": [ [0, 0, 0, "Use data-testid for E2E selectors instead of aria-label", "0"] diff --git a/packages/grafana-e2e-selectors/src/selectors/components.ts b/packages/grafana-e2e-selectors/src/selectors/components.ts index 83b53842e87..a4f953ae7d9 100644 --- a/packages/grafana-e2e-selectors/src/selectors/components.ts +++ b/packages/grafana-e2e-selectors/src/selectors/components.ts @@ -382,7 +382,7 @@ export const Components = { link: 'data-testid Dashboard link', }, LoadingIndicator: { - icon: 'Loading indicator', + icon: 'data-testid Loading indicator', }, CallToActionCard: { /** diff --git a/packages/grafana-ui/src/components/PanelChrome/LoadingIndicator.tsx b/packages/grafana-ui/src/components/PanelChrome/LoadingIndicator.tsx index e597c17ca3e..77255379cda 100644 --- a/packages/grafana-ui/src/components/PanelChrome/LoadingIndicator.tsx +++ b/packages/grafana-ui/src/components/PanelChrome/LoadingIndicator.tsx @@ -32,7 +32,7 @@ export const LoadingIndicator = ({ onCancel, loading }: LoadingIndicatorProps) = name="sync" size="sm" onClick={onCancel} - aria-label={selectors.components.LoadingIndicator.icon} + data-testid={selectors.components.LoadingIndicator.icon} /> ); diff --git a/public/app/features/variables/pickers/OptionsPicker/OptionPicker.test.tsx b/public/app/features/variables/pickers/OptionsPicker/OptionPicker.test.tsx index bb3a51b9ede..316daba5c47 100644 --- a/public/app/features/variables/pickers/OptionsPicker/OptionPicker.test.tsx +++ b/public/app/features/variables/pickers/OptionsPicker/OptionPicker.test.tsx @@ -111,7 +111,7 @@ describe('OptionPicker', () => { variable: { ...defaultVariable, state: LoadingState.Loading }, }); expect(getSubMenu('A + C')).toBeInTheDocument(); - expect(screen.getByLabelText(selectors.components.LoadingIndicator.icon)).toBeInTheDocument(); + expect(screen.getByTestId(selectors.components.LoadingIndicator.icon)).toBeInTheDocument(); }); it('link text should not be clickable', async () => { diff --git a/public/app/features/variables/pickers/shared/VariableLink.tsx b/public/app/features/variables/pickers/shared/VariableLink.tsx index 246a7a9cd1f..206056e750c 100644 --- a/public/app/features/variables/pickers/shared/VariableLink.tsx +++ b/public/app/features/variables/pickers/shared/VariableLink.tsx @@ -3,7 +3,8 @@ import React, { MouseEvent, useCallback } from 'react'; import { GrafanaTheme2 } from '@grafana/data'; import { selectors } from '@grafana/e2e-selectors'; -import { Icon, Tooltip, useStyles2 } from '@grafana/ui'; +import { Icon, useStyles2 } from '@grafana/ui'; +import { LoadingIndicator } from '@grafana/ui/src/components/PanelChrome/LoadingIndicator'; import { t } from 'app/core/internationalization'; import { ALL_VARIABLE_TEXT } from '../../constants'; @@ -40,7 +41,7 @@ export const VariableLink = ({ loading, disabled, onClick: propsOnClick, text, o id={id} > - + ); } @@ -75,28 +76,6 @@ const VariableLinkText = ({ text }: VariableLinkTextProps) => { ); }; -const LoadingIndicator = ({ onCancel }: Pick) => { - const onClick = useCallback( - (event: MouseEvent) => { - event.preventDefault(); - onCancel(); - }, - [onCancel] - ); - - return ( - - - - ); -}; - const getStyles = (theme: GrafanaTheme2) => ({ container: css` max-width: 500px;