From 66deb6940ae1ae523bae5b1b43c8b36f43198509 Mon Sep 17 00:00:00 2001
From: Roberto Jimenez Sanchez <roberto.jimenez@grafana.com>
Date: Tue, 2 Dec 2025 22:17:43 +0100
Subject: [PATCH] fix(typescript): fix type error in ShareExport.tsx

- Handle error case from makeExportableV1 which returns DashboardJson | { error: unknown }
- Change openSaveAsDialog to accept a more generic type that works with both Dashboard and DashboardJson
- Both Dashboard and DashboardJson have a title property, so the function works with either type
---
 .../dashboard/components/ShareModal/ShareExport.tsx      | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/public/app/features/dashboard/components/ShareModal/ShareExport.tsx b/public/app/features/dashboard/components/ShareModal/ShareExport.tsx
index 8989f941012..8e4d49fcd39 100644
--- a/public/app/features/dashboard/components/ShareModal/ShareExport.tsx
+++ b/public/app/features/dashboard/components/ShareModal/ShareExport.tsx
@@ -35,6 +35,10 @@ export const ShareExport = memo(({ dashboard, panel, onDismiss }: Props) => {
 
     if (shareExternally) {
       makeExportableV1(dashboard).then((dashboardJson) => {
+        if ('error' in dashboardJson) {
+          console.error('Failed to export dashboard:', dashboardJson.error);
+          return;
+        }
         openSaveAsDialog(dashboardJson);
       });
     } else {
@@ -57,13 +61,14 @@ export const ShareExport = memo(({ dashboard, panel, onDismiss }: Props) => {
     }
   };
 
-  const openSaveAsDialog = (dash: Dashboard) => {
+  const openSaveAsDialog = (dash: { title?: string; [key: string]: unknown }) => {
     const dashboardJsonPretty = JSON.stringify(dash, null, 2);
     const blob = new Blob([dashboardJsonPretty], {
       type: 'application/json;charset=utf-8',
     });
     const time = new Date().getTime();
-    saveAs(blob, `${dash.title}-${time}.json`);
+    const title = dash.title && typeof dash.title === 'string' ? dash.title : 'dashboard';
+    saveAs(blob, `${title}-${time}.json`);
   };
 
   const openJsonModal = (clone: object) => {