From 66f941adb80875754e211b2f495bca0be899e156 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Agn=C3=A8s=20Toulet?= <35176601+AgnesToulet@users.noreply.github.com> Date: Wed, 20 Jul 2022 12:54:26 +0200 Subject: [PATCH] RBAC: Add RBAC for data source insights (#51496) --- public/app/features/datasources/state/navModel.ts | 4 +++- public/app/types/accessControl.ts | 1 + 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/public/app/features/datasources/state/navModel.ts b/public/app/features/datasources/state/navModel.ts index 9c735a34bc6..3b153768a4e 100644 --- a/public/app/features/datasources/state/navModel.ts +++ b/public/app/features/datasources/state/navModel.ts @@ -94,7 +94,9 @@ export function buildNavModel(dataSource: DataSourceSettings, plugin: GenericDat } if (featureEnabled('analytics')) { - navModel.children!.push(analytics); + if (contextSrv.hasPermission(AccessControlAction.DataSourcesInsightsRead)) { + navModel.children!.push(analytics); + } } else if (highlightsEnabled && !isLoadingNav) { navModel.children!.push({ ...analytics, diff --git a/public/app/types/accessControl.ts b/public/app/types/accessControl.ts index f7be002eb36..a1ae94eeb4c 100644 --- a/public/app/types/accessControl.ts +++ b/public/app/types/accessControl.ts @@ -50,6 +50,7 @@ export enum AccessControlAction { DataSourcesWrite = 'datasources:write', DataSourcesDelete = 'datasources:delete', DataSourcesPermissionsRead = 'datasources.permissions:read', + DataSourcesInsightsRead = 'datasources.insights:read', ActionServerStatsRead = 'server.stats:read',