From 67449b95e9683eb7f03a46e91a3a8745f88b9a86 Mon Sep 17 00:00:00 2001 From: Will Browne Date: Wed, 27 Oct 2021 14:57:06 +0100 Subject: [PATCH] dispatch with context where missing (#40810) --- pkg/api/dashboard.go | 2 +- pkg/services/cleanup/cleanup.go | 2 +- pkg/services/search/service.go | 5 +++-- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/pkg/api/dashboard.go b/pkg/api/dashboard.go index 4eef73aeaa0..d973fb852c4 100644 --- a/pkg/api/dashboard.go +++ b/pkg/api/dashboard.go @@ -659,7 +659,7 @@ func (hs *HTTPServer) RestoreDashboardVersion(c *models.ReqContext, apiCmd dtos. func GetDashboardTags(c *models.ReqContext) { query := models.GetDashboardTagsQuery{OrgId: c.OrgId} - err := bus.Dispatch(&query) + err := bus.DispatchCtx(c.Req.Context(), &query) if err != nil { c.JsonApiErr(500, "Failed to get tags from database", err) return diff --git a/pkg/services/cleanup/cleanup.go b/pkg/services/cleanup/cleanup.go index c92b9053f81..48ec74a3c4a 100644 --- a/pkg/services/cleanup/cleanup.go +++ b/pkg/services/cleanup/cleanup.go @@ -127,7 +127,7 @@ func (srv *CleanUpService) shouldCleanupTempFile(filemtime time.Time, now time.T func (srv *CleanUpService) deleteExpiredSnapshots() { cmd := models.DeleteExpiredSnapshotsCommand{} - if err := bus.Dispatch(&cmd); err != nil { + if err := bus.DispatchCtx(context.TODO(), &cmd); err != nil { srv.log.Error("Failed to delete expired snapshots", "error", err.Error()) } else { srv.log.Debug("Deleted expired snapshots", "rows affected", cmd.DeletedRows) diff --git a/pkg/services/search/service.go b/pkg/services/search/service.go index a42294b792e..81f9be4f414 100644 --- a/pkg/services/search/service.go +++ b/pkg/services/search/service.go @@ -1,6 +1,7 @@ package search import ( + "context" "sort" "github.com/grafana/grafana/pkg/setting" @@ -83,7 +84,7 @@ func (s *SearchService) searchHandler(query *Query) error { dashboardQuery.Sort = sortOpt } - if err := bus.Dispatch(&dashboardQuery); err != nil { + if err := bus.DispatchCtx(context.TODO(), &dashboardQuery); err != nil { return err } @@ -119,7 +120,7 @@ func setStarredDashboards(userID int64, hits []*Hit) error { UserId: userID, } - if err := bus.Dispatch(&query); err != nil { + if err := bus.DispatchCtx(context.TODO(), &query); err != nil { return err }