Chore: add/update sqlstore-related helper functions (#77408)

* add/update sqlstore-related helper functions

* add documentation & tests for InsertQuery and UpdateQuery, make generated SQL deterministic by sorting columns

* remove old log line

pkg/services/store/entity/sqlstash/querybuilder.go

@@ -1,8 +1,13 @@
 package sqlstash
 
-import "strings"
+import (
+	"strings"
+
+	"github.com/grafana/grafana/pkg/services/sqlstore/migrator"
+)
 
 type selectQuery struct {
+	dialect  migrator.Dialect
 	fields   []string // SELECT xyz
 	from     string   // FROM object
 	limit    int64
@@ -12,21 +17,27 @@ type selectQuery struct {
 	args  []any
 }
 
-func (q *selectQuery) addWhere(f string, val any) {
-	q.args = append(q.args, val)
-	q.where = append(q.where, f+"=?")
+func (q *selectQuery) addWhere(f string, val ...any) {
+	q.args = append(q.args, val...)
+	// if the field contains a question mark, we assume it's a raw where clause
+	if strings.Contains(f, "?") {
+		q.where = append(q.where, f)
+		// otherwise we assume it's a field name
+	} else {
+		q.where = append(q.where, q.dialect.Quote(f)+"=?")
+	}
 }
 
 func (q *selectQuery) addWhereInSubquery(f string, subquery string, subqueryArgs []any) {
 	q.args = append(q.args, subqueryArgs...)
-	q.where = append(q.where, f+" IN ("+subquery+")")
+	q.where = append(q.where, q.dialect.Quote(f)+" IN ("+subquery+")")
 }
 
 func (q *selectQuery) addWhereIn(f string, vals []string) {
 	count := len(vals)
 	if count > 1 {
 		sb := strings.Builder{}
-		sb.WriteString(f)
+		sb.WriteString(q.dialect.Quote(f))
 		sb.WriteString(" IN (")
 		for i := 0; i < count; i++ {
 			if i > 0 {
@@ -46,7 +57,11 @@ func (q *selectQuery) toQuery() (string, []any) {
 	args := q.args
 	sb := strings.Builder{}
 	sb.WriteString("SELECT ")
-	sb.WriteString(strings.Join(q.fields, ","))
+	quotedFields := make([]string, len(q.fields))
+	for i, f := range q.fields {
+		quotedFields[i] = q.dialect.Quote(f)
+	}
+	sb.WriteString(strings.Join(quotedFields, ","))
 	sb.WriteString(" FROM ")
 	sb.WriteString(q.from)