From 68507e88552b0101ae3af273b06c3b1baf70529d Mon Sep 17 00:00:00 2001 From: Mario Trangoni Date: Mon, 15 Oct 2018 21:30:42 +0200 Subject: [PATCH] pkg/services/alerting/reader.go: Fix should use for range instead of for { select {} }. $ gometalinter --vendor --deadline 10m --disable-all --enable=megacheck ./... pkg/services/alerting/reader.go:37:2:warning: should use for range instead of for { select {} } (S1000) (megacheck) --- pkg/services/alerting/reader.go | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/pkg/services/alerting/reader.go b/pkg/services/alerting/reader.go index 627159c286b..2cdbc57b41d 100644 --- a/pkg/services/alerting/reader.go +++ b/pkg/services/alerting/reader.go @@ -34,11 +34,8 @@ func NewRuleReader() *DefaultRuleReader { func (arr *DefaultRuleReader) initReader() { heartbeat := time.NewTicker(time.Second * 10) - for { - select { - case <-heartbeat.C: - arr.heartbeat() - } + for range heartbeat.C { + arr.heartbeat() } }