From 68f01d57d3fdd1f0c80eb702a86565243445e4fe Mon Sep 17 00:00:00 2001 From: bergquist Date: Fri, 3 Jun 2016 08:44:22 +0200 Subject: [PATCH] tech(alerting): use range in loops when possible --- pkg/services/alerting/alerting.go | 18 +++++++----------- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/pkg/services/alerting/alerting.go b/pkg/services/alerting/alerting.go index 8871e132f39..1ebc36550d8 100644 --- a/pkg/services/alerting/alerting.go +++ b/pkg/services/alerting/alerting.go @@ -63,23 +63,19 @@ func (scheduler *Scheduler) updateJobs(alertRuleFn func() []m.AlertRule) { jobs := make(map[int64]*m.AlertJob, 0) rules := alertRuleFn() - for i := 0; i < len(rules); i++ { - rule := rules[i] - /* - jobs[rule.Id] = &m.AlertJob{ - Offset: int64(i), - Running: false, - Rule: rule, - } - */ - - job := &m.AlertJob{} + for i, rule := range rules { + var job *m.AlertJob if scheduler.jobs[rule.Id] != nil { job = scheduler.jobs[rule.Id] + } else { + job = &m.AlertJob{ + Running: false, + } } job.Rule = rule job.Offset = int64(i) + jobs[rule.Id] = job }