Move SignedInUser to user service and RoleType and Roles to org (#53445)
* Move SignedInUser to user service and RoleType and Roles to org * Use go naming convention for roles * Fix some imports and leftovers * Fix ldap debug test * Fix lint * Fix lint 2 * Fix lint 3 * Fix type and not needed conversion * Clean up messages in api tests * Clean up api tests 2
This commit is contained in:
@@ -18,6 +18,7 @@ import (
|
||||
"github.com/grafana/grafana/pkg/infra/log"
|
||||
"github.com/grafana/grafana/pkg/models"
|
||||
"github.com/grafana/grafana/pkg/services/login"
|
||||
"github.com/grafana/grafana/pkg/services/org"
|
||||
)
|
||||
|
||||
// IConnection is interface for LDAP connection manipulation
|
||||
@@ -442,7 +443,7 @@ func (server *Server) buildGrafanaUser(user *ldap.Entry) (*models.ExternalUserIn
|
||||
Login: getAttribute(attrs.Username, user),
|
||||
Email: getAttribute(attrs.Email, user),
|
||||
Groups: memberOf,
|
||||
OrgRoles: map[int64]models.RoleType{},
|
||||
OrgRoles: map[int64]org.RoleType{},
|
||||
}
|
||||
|
||||
for _, group := range server.Config.Groups {
|
||||
|
||||
@@ -11,6 +11,7 @@ import (
|
||||
|
||||
"github.com/grafana/grafana/pkg/infra/log"
|
||||
"github.com/grafana/grafana/pkg/models"
|
||||
"github.com/grafana/grafana/pkg/services/org"
|
||||
)
|
||||
|
||||
func TestServer_getSearchRequest(t *testing.T) {
|
||||
@@ -126,7 +127,7 @@ func TestSerializeUsers(t *testing.T) {
|
||||
Groups: []*GroupToOrgRole{{
|
||||
GroupDN: "foo",
|
||||
OrgId: 1,
|
||||
OrgRole: models.ROLE_EDITOR,
|
||||
OrgRole: org.RoleEditor,
|
||||
}},
|
||||
},
|
||||
Connection: &MockConnection{},
|
||||
@@ -180,7 +181,7 @@ func TestServer_validateGrafanaUser(t *testing.T) {
|
||||
|
||||
user := &models.ExternalUserInfo{
|
||||
Login: "markelog",
|
||||
OrgRoles: map[int64]models.RoleType{
|
||||
OrgRoles: map[int64]org.RoleType{
|
||||
1: "test",
|
||||
},
|
||||
}
|
||||
|
||||
@@ -8,7 +8,7 @@ import (
|
||||
"github.com/BurntSushi/toml"
|
||||
|
||||
"github.com/grafana/grafana/pkg/infra/log"
|
||||
"github.com/grafana/grafana/pkg/models"
|
||||
"github.com/grafana/grafana/pkg/services/org"
|
||||
"github.com/grafana/grafana/pkg/setting"
|
||||
)
|
||||
|
||||
@@ -62,7 +62,7 @@ type GroupToOrgRole struct {
|
||||
// This pointer specifies if setting was set (for backwards compatibility)
|
||||
IsGrafanaAdmin *bool `toml:"grafana_admin"`
|
||||
|
||||
OrgRole models.RoleType `toml:"org_role"`
|
||||
OrgRole org.RoleType `toml:"org_role"`
|
||||
}
|
||||
|
||||
// logger for all LDAP stuff
|
||||
|
||||
Reference in New Issue
Block a user