From 6c7290164e421158ced9e623a266548d75d1550f Mon Sep 17 00:00:00 2001 From: Oscar Kilhed Date: Wed, 28 Apr 2021 09:58:53 +0200 Subject: [PATCH] Fix datalink suggestions (#33411) --- .../dashboard/components/PanelEditor/OptionsPaneOptions.tsx | 2 +- .../components/PanelEditor/getVizualizationOptions.tsx | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/public/app/features/dashboard/components/PanelEditor/OptionsPaneOptions.tsx b/public/app/features/dashboard/components/PanelEditor/OptionsPaneOptions.tsx index f366f085665..e3a6c3ac65a 100644 --- a/public/app/features/dashboard/components/PanelEditor/OptionsPaneOptions.tsx +++ b/public/app/features/dashboard/components/PanelEditor/OptionsPaneOptions.tsx @@ -32,7 +32,7 @@ export const OptionsPaneOptions: React.FC = (props) => { () => [getPanelFrameCategory(props), getVizualizationOptions(props), getFieldOverrideCategories(props)], // eslint-disable-next-line react-hooks/exhaustive-deps - [panel.configRev] + [panel.configRev, props.data] ); const mainBoxElements: React.ReactNode[] = []; diff --git a/public/app/features/dashboard/components/PanelEditor/getVizualizationOptions.tsx b/public/app/features/dashboard/components/PanelEditor/getVizualizationOptions.tsx index cce260e7393..5222dd8156c 100644 --- a/public/app/features/dashboard/components/PanelEditor/getVizualizationOptions.tsx +++ b/public/app/features/dashboard/components/PanelEditor/getVizualizationOptions.tsx @@ -1,7 +1,7 @@ import React from 'react'; import { StandardEditorContext, VariableSuggestionsScope } from '@grafana/data'; import { get as lodashGet, set as lodashSet } from 'lodash'; -import { getPanelOptionsVariableSuggestions } from 'app/features/panel/panellinks/link_srv'; +import { getDataLinksVariableSuggestions } from 'app/features/panel/panellinks/link_srv'; import { OptionPaneRenderProps } from './types'; import { updateDefaultFieldConfigValue } from './utils'; import { OptionsPaneItemDescriptor } from './OptionsPaneItemDescriptor'; @@ -19,7 +19,7 @@ export function getVizualizationOptions(props: OptionPaneRenderProps): OptionsPa options: currentOptions, eventBus: dashboard.events, getSuggestions: (scope?: VariableSuggestionsScope) => { - return getPanelOptionsVariableSuggestions(plugin, data?.series); + return data ? getDataLinksVariableSuggestions(data.series, scope) : []; }, };