From 6c91b65aca29aaaf587e89824e4697572d708785 Mon Sep 17 00:00:00 2001
From: Juan Cabanas <juan.cabanas@grafana.com>
Date: Tue, 1 Oct 2024 09:46:32 -0300
Subject: [PATCH] ShareButton: Split copy link button and dropdown (#94020)

---
 .../sharing/ShareButton/ShareButton.tsx       | 19 +++++++++++++------
 .../dashboard-scene/utils/interactions.ts     |  3 ---
 2 files changed, 13 insertions(+), 9 deletions(-)

diff --git a/public/app/features/dashboard-scene/sharing/ShareButton/ShareButton.tsx b/public/app/features/dashboard-scene/sharing/ShareButton/ShareButton.tsx
index f5574ea89f9..a7f6fd46890 100644
--- a/public/app/features/dashboard-scene/sharing/ShareButton/ShareButton.tsx
+++ b/public/app/features/dashboard-scene/sharing/ShareButton/ShareButton.tsx
@@ -1,9 +1,11 @@
+import { css } from '@emotion/css';
 import { useCallback, useState } from 'react';
 import { useAsyncFn } from 'react-use';
 
+import { GrafanaTheme2 } from '@grafana/data';
 import { selectors as e2eSelectors } from '@grafana/e2e-selectors';
 import { VizPanel } from '@grafana/scenes';
-import { Button, ButtonGroup, Dropdown } from '@grafana/ui';
+import { Button, ButtonGroup, Dropdown, useStyles2 } from '@grafana/ui';
 import { t, Trans } from 'app/core/internationalization';
 
 import { DashboardScene } from '../../scene/DashboardScene';
@@ -15,6 +17,7 @@ import { buildShareUrl } from './utils';
 const newShareButtonSelector = e2eSelectors.pages.Dashboard.DashNav.newShareButton;
 
 export default function ShareButton({ dashboard, panel }: { dashboard: DashboardScene; panel?: VizPanel }) {
+  const styles = useStyles2(getStyles);
   const [isOpen, setIsOpen] = useState(false);
 
   const [_, buildUrl] = useAsyncFn(async () => {
@@ -23,17 +26,13 @@ export default function ShareButton({ dashboard, panel }: { dashboard: Dashboard
   }, [dashboard]);
 
   const onMenuClick = useCallback((isOpen: boolean) => {
-    if (isOpen) {
-      DashboardInteractions.toolbarShareDropdownClick();
-    }
-
     setIsOpen(isOpen);
   }, []);
 
   const MenuActions = () => <ShareMenu dashboard={dashboard} />;
 
   return (
-    <ButtonGroup data-testid={newShareButtonSelector.container}>
+    <ButtonGroup data-testid={newShareButtonSelector.container} className={styles.container}>
       <Button
         data-testid={newShareButtonSelector.shareLink}
         size="sm"
@@ -48,3 +47,11 @@ export default function ShareButton({ dashboard, panel }: { dashboard: Dashboard
     </ButtonGroup>
   );
 }
+
+function getStyles(theme: GrafanaTheme2) {
+  return {
+    container: css({
+      gap: 1,
+    }),
+  };
+}
diff --git a/public/app/features/dashboard-scene/utils/interactions.ts b/public/app/features/dashboard-scene/utils/interactions.ts
index 6ed95fe6cb8..fef5f346551 100644
--- a/public/app/features/dashboard-scene/utils/interactions.ts
+++ b/public/app/features/dashboard-scene/utils/interactions.ts
@@ -28,9 +28,6 @@ export const DashboardInteractions = {
   toolbarShareClick: () => {
     reportDashboardInteraction('toolbar_actions_clicked', { item: 'share' });
   },
-  toolbarShareDropdownClick: () => {
-    reportDashboardInteraction('toolbar_actions_clicked', { item: 'share_dropdown' });
-  },
   toolbarAddClick: () => {
     reportDashboardInteraction('toolbar_actions_clicked', { item: 'add' });
   },