From 6ce0efeb41e7c9c4392f439a9b10e23486e2a094 Mon Sep 17 00:00:00 2001 From: Giuseppe Guerra Date: Fri, 16 Feb 2024 13:46:14 +0100 Subject: [PATCH] Plugins: Enable feature toggle angularDeprecationUI by default (#82880) * Plugins: Enable feature toggle angularDeprecationUI by default * Clarified feature toggle description --- .../configure-grafana/feature-toggles/index.md | 2 +- pkg/services/featuremgmt/registry.go | 5 +++-- pkg/services/featuremgmt/toggles_gen.csv | 2 +- pkg/services/featuremgmt/toggles_gen.go | 2 +- pkg/services/featuremgmt/toggles_gen.json | 11 +++++++---- 5 files changed, 13 insertions(+), 9 deletions(-) diff --git a/docs/sources/setup-grafana/configure-grafana/feature-toggles/index.md b/docs/sources/setup-grafana/configure-grafana/feature-toggles/index.md index fa1734778d7..30f711ef6ad 100644 --- a/docs/sources/setup-grafana/configure-grafana/feature-toggles/index.md +++ b/docs/sources/setup-grafana/configure-grafana/feature-toggles/index.md @@ -48,6 +48,7 @@ Some features are enabled by default. You can disable these feature by setting t | `prometheusConfigOverhaulAuth` | Update the Prometheus configuration page with the new auth component | Yes | | `influxdbSqlSupport` | Enable InfluxDB SQL query language support with new querying UI | Yes | | `alertingNoDataErrorExecution` | Changes how Alerting state manager handles execution of NoData/Error | Yes | +| `angularDeprecationUI` | Display Angular warnings in dashboards and panels | Yes | | `alertingInsights` | Show the new alerting insights landing page | Yes | | `cloudWatchWildCardDimensionValues` | Fetches dimension values from CloudWatch to correctly label wildcard dimensions | Yes | | `panelMonitoring` | Enables panel monitoring through logs and measurements | Yes | @@ -145,7 +146,6 @@ Experimental features might be changed or removed without prior notice. | `metricsSummary` | Enables metrics summary queries in the Tempo data source | | `featureToggleAdminPage` | Enable admin page for managing feature toggles from the Grafana front-end | | `permissionsFilterRemoveSubquery` | Alternative permission filter implementation that does not use subqueries for fetching the dashboard folder | -| `angularDeprecationUI` | Display new Angular deprecation-related UI features | | `sseGroupByDatasource` | Send query to the same datasource in a single request when using server side expressions. The `cloudWatchBatchQueries` feature toggle should be enabled if this used with CloudWatch. | | `libraryPanelRBAC` | Enables RBAC support for library panels | | `wargamesTesting` | Placeholder feature flag for internal testing | diff --git a/pkg/services/featuremgmt/registry.go b/pkg/services/featuremgmt/registry.go index 98083ef9983..53f52a327d1 100644 --- a/pkg/services/featuremgmt/registry.go +++ b/pkg/services/featuremgmt/registry.go @@ -718,10 +718,11 @@ var ( }, { Name: "angularDeprecationUI", - Description: "Display new Angular deprecation-related UI features", - Stage: FeatureStageExperimental, + Description: "Display Angular warnings in dashboards and panels", + Stage: FeatureStageGeneralAvailability, FrontendOnly: true, Owner: grafanaPluginsPlatformSquad, + Expression: "true", // Enabled by default }, { Name: "dashgpt", diff --git a/pkg/services/featuremgmt/toggles_gen.csv b/pkg/services/featuremgmt/toggles_gen.csv index 0656906e50f..d4b46223ef9 100644 --- a/pkg/services/featuremgmt/toggles_gen.csv +++ b/pkg/services/featuremgmt/toggles_gen.csv @@ -94,7 +94,7 @@ prometheusConfigOverhaulAuth,GA,@grafana/observability-metrics,false,false,false configurableSchedulerTick,experimental,@grafana/alerting-squad,false,true,false influxdbSqlSupport,GA,@grafana/observability-metrics,false,true,false alertingNoDataErrorExecution,GA,@grafana/alerting-squad,false,true,false -angularDeprecationUI,experimental,@grafana/plugins-platform-backend,false,false,true +angularDeprecationUI,GA,@grafana/plugins-platform-backend,false,false,true dashgpt,preview,@grafana/dashboards-squad,false,false,true reportingRetries,preview,@grafana/sharing-squad,false,true,false sseGroupByDatasource,experimental,@grafana/observability-metrics,false,false,false diff --git a/pkg/services/featuremgmt/toggles_gen.go b/pkg/services/featuremgmt/toggles_gen.go index 573bb448e26..70fcfc2c6b6 100644 --- a/pkg/services/featuremgmt/toggles_gen.go +++ b/pkg/services/featuremgmt/toggles_gen.go @@ -388,7 +388,7 @@ const ( FlagAlertingNoDataErrorExecution = "alertingNoDataErrorExecution" // FlagAngularDeprecationUI - // Display new Angular deprecation-related UI features + // Display Angular warnings in dashboards and panels FlagAngularDeprecationUI = "angularDeprecationUI" // FlagDashgpt diff --git a/pkg/services/featuremgmt/toggles_gen.json b/pkg/services/featuremgmt/toggles_gen.json index 17efb7f3795..3e5ffb8f7fe 100644 --- a/pkg/services/featuremgmt/toggles_gen.json +++ b/pkg/services/featuremgmt/toggles_gen.json @@ -527,12 +527,15 @@ { "metadata": { "name": "angularDeprecationUI", - "resourceVersion": "1707928895402", - "creationTimestamp": "2024-02-14T16:41:35Z" + "resourceVersion": "1708080773145", + "creationTimestamp": "2024-02-14T16:41:35Z", + "annotations": { + "grafana.app/updatedTimestamp": "2024-02-16 10:52:53.145203323 +0000 UTC" + } }, "spec": { - "description": "Display new Angular deprecation-related UI features", - "stage": "experimental", + "description": "Display Angular warnings in dashboards and panels", + "stage": "GA", "codeowner": "@grafana/plugins-platform-backend", "frontend": true }