Cleanup of old search functionality (#110861)

* Remove support for initMinSize.
Remove support for searchAfterWrite option, now it defaults to true.

* Remove reference to deprecated feature toggle.

* Remove feature toggle completely.

* Remove code related to indexing on watch events.

* Fix compilation error.

* Remove unused field.

pkg/storage/unified/sql/server.go

@@ -12,6 +12,7 @@ import (
 	"github.com/grafana/authlib/types"
 	"github.com/grafana/dskit/ring"
 	"github.com/grafana/dskit/services"
+
 	infraDB "github.com/grafana/grafana/pkg/infra/db"
 	secrets "github.com/grafana/grafana/pkg/registry/apis/secret/contracts"
 	inlinesecurevalue "github.com/grafana/grafana/pkg/registry/apis/secret/inline"
@@ -119,7 +120,6 @@ func NewResourceServer(
 	serverOptions.QOSQueue = opts.QOSQueue
 	serverOptions.Ring = opts.Ring
 	serverOptions.RingLifecycler = opts.RingLifecycler
-	serverOptions.SearchAfterWrite = opts.Features.IsEnabledGlobally(featuremgmt.FlagUnifiedStorageSearchAfterWriteExperimentalAPI)
 
 	return resource.NewResourceServer(serverOptions)
 }

pkg/storage/unified/sql/test/benchmark_test.go

@@ -2,18 +2,14 @@ package test
 
 import (
 	"context"
-	"os"
 	"testing"
 	"time"
 
 	"github.com/stretchr/testify/require"
 
 	"github.com/grafana/grafana/pkg/infra/db"
-	"github.com/grafana/grafana/pkg/infra/tracing"
-	"github.com/grafana/grafana/pkg/services/featuremgmt"
 	"github.com/grafana/grafana/pkg/setting"
 	"github.com/grafana/grafana/pkg/storage/unified/resource"
-	"github.com/grafana/grafana/pkg/storage/unified/search"
 	"github.com/grafana/grafana/pkg/storage/unified/sql"
 	"github.com/grafana/grafana/pkg/storage/unified/sql/db/dbimpl"
 	test "github.com/grafana/grafana/pkg/storage/unified/testing"
@@ -46,48 +42,3 @@ func TestIntegrationBenchmarkSQLStorageBackend(t *testing.T) {
 	}
 	test.BenchmarkStorageBackend(t, newTestBackend(t), opts)
 }
-
-func TestIntegrationBenchmarkResourceServer(t *testing.T) {
-	t.Skip("skipping slow test, causing CI to fail due to timeout")
-
-	testutil.SkipIntegrationTestInShortMode(t)
-
-	ctx := context.Background()
-	opts := &test.BenchmarkOptions{
-		NumResources:     1000,
-		Concurrency:      10,
-		NumNamespaces:    1,
-		NumGroups:        1,
-		NumResourceTypes: 1,
-	}
-	tempDir := t.TempDir()
-	t.Cleanup(func() {
-		_ = os.RemoveAll(tempDir)
-	})
-	// Create a new bleve backend
-	search, err := search.NewBleveBackend(search.BleveOptions{
-		Root: tempDir,
-	}, tracing.NewNoopTracerService(), featuremgmt.WithFeatures(), nil)
-	require.NoError(t, err)
-	require.NotNil(t, search)
-
-	t.Cleanup(search.CloseAllIndexes)
-
-	// Create a new resource backend
-	dbstore := db.InitTestDB(t)
-	eDB, err := dbimpl.ProvideResourceDB(dbstore, setting.NewCfg(), nil)
-	require.NoError(t, err)
-	require.NotNil(t, eDB)
-
-	storage, err := sql.NewBackend(sql.BackendOptions{
-		DBProvider: eDB,
-		IsHA:       false,
-	})
-	require.NoError(t, err)
-	require.NotNil(t, storage)
-
-	err = storage.Init(ctx)
-	require.NoError(t, err)
-
-	test.BenchmarkIndexServer(t, ctx, storage, search, opts)
-}