diff --git a/packages/grafana-prometheus/src/configuration/AlertingSettingsOverhaul.tsx b/packages/grafana-prometheus/src/configuration/AlertingSettingsOverhaul.tsx index 13ee0ac5485..94ea6281492 100644 --- a/packages/grafana-prometheus/src/configuration/AlertingSettingsOverhaul.tsx +++ b/packages/grafana-prometheus/src/configuration/AlertingSettingsOverhaul.tsx @@ -72,13 +72,13 @@ export function AlertingSettingsOverhaul({ - + Allow this data source to be selected as a target for writing recording rules. {' '} {docsTip()} diff --git a/packages/grafana-prometheus/src/locales/en-US/grafana-prometheus.json b/packages/grafana-prometheus/src/locales/en-US/grafana-prometheus.json index a7a4e3c6705..37d6b802968 100644 --- a/packages/grafana-prometheus/src/locales/en-US/grafana-prometheus.json +++ b/packages/grafana-prometheus/src/locales/en-US/grafana-prometheus.json @@ -110,11 +110,11 @@ }, "configuration": { "alerting-settings-overhaul": { - "label-manage-alerts-via-alerting-ui": "Manage alerts via Alerting UI", "label-allow-as-recording-rules-target": "Allow as recording rules target", + "label-manage-alerts-via-alerting-ui": "Manage alerts via Alerting UI", "title-alerting": "Alerting", - "tooltip-manage-alerts-via-alerting-ui": "Manage alert rules for this data source. To manage other alerting resources, add an Alertmanager data source.", - "tooltip-allow-as-recording-rules-target": "Allow this data source to be selected as a target for writing recording rules." + "tooltip-allow-as-recording-rules-target": "Allow this data source to be selected as a target for writing recording rules.", + "tooltip-manage-alerts-via-alerting-ui": "Manage alert rules for this data source. To manage other alerting resources, add an Alertmanager data source." }, "config-editor": { "browser-access-mode-error": "Browser access mode in the Prometheus data source is no longer available. Switch to server access mode.", diff --git a/packages/grafana-ui/src/components/Drawer/Drawer.tsx b/packages/grafana-ui/src/components/Drawer/Drawer.tsx index 5af570c7fe9..070bef4372e 100644 --- a/packages/grafana-ui/src/components/Drawer/Drawer.tsx +++ b/packages/grafana-ui/src/components/Drawer/Drawer.tsx @@ -143,17 +143,17 @@ export function Drawer({ onMouseDown={onMouseDown} onTouchStart={onTouchStart} /> - {typeof title === 'string' && ( -
-
- -
+
+
+ +
+ {typeof title === 'string' ? (
{title} @@ -163,11 +163,12 @@ export function Drawer({ {subtitle}
)} - {tabs &&
{tabs}
}
-
- )} - {typeof title !== 'string' && title} + ) : ( + title + )} + {tabs &&
{tabs}
} + {!scrollableContent ? content : {content}} diff --git a/public/app/core/components/AppChrome/News/NewsDrawer.tsx b/public/app/core/components/AppChrome/News/NewsDrawer.tsx index f2122497204..f4fc23b6b3c 100644 --- a/public/app/core/components/AppChrome/News/NewsDrawer.tsx +++ b/public/app/core/components/AppChrome/News/NewsDrawer.tsx @@ -1,9 +1,8 @@ import { css } from '@emotion/css'; import { GrafanaTheme2 } from '@grafana/data'; -import { selectors } from '@grafana/e2e-selectors'; import { t } from '@grafana/i18n'; -import { IconButton, Drawer, useStyles2, Text } from '@grafana/ui'; +import { Drawer, useStyles2, Text } from '@grafana/ui'; import { DEFAULT_FEED_URL } from 'app/plugins/panel/news/constants'; import grotNewsSvg from 'img/grot-news.svg'; @@ -31,15 +30,6 @@ export function NewsContainer({ onClose }: NewsContainerProps) { > Grot reading news -
- -
} onClose={onClose} @@ -57,7 +47,6 @@ const getStyles = (theme: GrafanaTheme2) => { alignItems: `center`, justifyContent: `center`, gap: theme.spacing(2), - borderBottom: `1px solid ${theme.colors.border.weak}`, }), grot: css({ display: `flex`, @@ -70,10 +59,5 @@ const getStyles = (theme: GrafanaTheme2) => { height: `75px`, }, }), - actions: css({ - position: 'absolute', - right: theme.spacing(1), - top: theme.spacing(2), - }), }; }; diff --git a/public/locales/en-US/grafana.json b/public/locales/en-US/grafana.json index ac12d0b0f21..456c2493fe3 100644 --- a/public/locales/en-US/grafana.json +++ b/public/locales/en-US/grafana.json @@ -8505,9 +8505,6 @@ "rss-button": "Latest from the blog" }, "news": { - "drawer": { - "close": "Close drawer" - }, "link-title": "Go to Grafana labs blog", "news-panel": { "body-error-loading-rss-feed": "Make sure that the feed URL is correct and that CORS is configured correctly on the server. See <2>News panel documentation.",