From 707198227c30c48c936be26ee01e3bddd99f8d18 Mon Sep 17 00:00:00 2001 From: Christian Segundo <36006540+someone-stole-my-name@users.noreply.github.com> Date: Tue, 20 Dec 2022 14:35:43 +0100 Subject: [PATCH] Auth: Log a more useful msg if no OAuth provider configured (#56722) Log a useful msg if no oauth provider configured When a user doesn't configure an OAuth provider and uses auto login, Grafana logs a misleading message indicating that he has multiple providers configured. --- pkg/api/login.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/pkg/api/login.go b/pkg/api/login.go index 17c23dcd745..1ed59213fbe 100644 --- a/pkg/api/login.go +++ b/pkg/api/login.go @@ -142,9 +142,12 @@ func (hs *HTTPServer) tryOAuthAutoLogin(c *models.ReqContext) bool { return false } oauthInfos := hs.SocialService.GetOAuthInfoProviders() - if len(oauthInfos) != 1 { + if len(oauthInfos) > 1 { c.Logger.Warn("Skipping OAuth auto login because multiple OAuth providers are configured") return false + } else if len(oauthInfos) == 0 { + c.Logger.Warn("Skipping OAuth auto login because no OAuth providers are configured") + return false } for key := range oauthInfos { redirectUrl := hs.Cfg.AppSubURL + "/login/" + key