diff --git a/public/app/features/dashboard/components/DashboardSettings/VersionsSettings.test.tsx b/public/app/features/dashboard/components/DashboardSettings/VersionsSettings.test.tsx index 75baf12aa16..8721e0e98e9 100644 --- a/public/app/features/dashboard/components/DashboardSettings/VersionsSettings.test.tsx +++ b/public/app/features/dashboard/components/DashboardSettings/VersionsSettings.test.tsx @@ -160,11 +160,6 @@ describe('VersionSettings', () => { expect(compareButton).toBeEnabled(); - await user.click(within(tableBody).getAllByRole('checkbox')[1]); - - expect(compareButton).toBeDisabled(); - - await user.click(within(tableBody).getAllByRole('checkbox')[1]); await user.click(compareButton); await waitFor(() => expect(screen.getByRole('heading', { name: /versions comparing 2 11/i })).toBeInTheDocument()); diff --git a/public/app/features/dashboard/components/DashboardSettings/VersionsSettings.tsx b/public/app/features/dashboard/components/DashboardSettings/VersionsSettings.tsx index 448683461b9..f096c5d3e90 100644 --- a/public/app/features/dashboard/components/DashboardSettings/VersionsSettings.tsx +++ b/public/app/features/dashboard/components/DashboardSettings/VersionsSettings.tsx @@ -135,7 +135,7 @@ export class VersionsSettings extends PureComponent { render() { const { versions, viewMode, baseInfo, newInfo, isNewLatest, isLoading, diffData } = this.state; - const canCompare = versions.filter((version) => version.checked).length !== 2; + const canCompare = versions.filter((version) => version.checked).length === 2; const showButtons = versions.length > 1; const hasMore = versions.length >= this.limit; @@ -169,7 +169,7 @@ export class VersionsSettings extends PureComponent { {isLoading ? ( ) : ( - + )} {this.state.isAppending && } {showButtons && ( diff --git a/public/app/features/dashboard/components/VersionHistory/VersionHistoryButtons.tsx b/public/app/features/dashboard/components/VersionHistory/VersionHistoryButtons.tsx index c8d0d1ad083..f483d276b32 100644 --- a/public/app/features/dashboard/components/VersionHistory/VersionHistoryButtons.tsx +++ b/public/app/features/dashboard/components/VersionHistory/VersionHistoryButtons.tsx @@ -23,7 +23,7 @@ export const VersionsHistoryButtons: React.FC = ({ )} - diff --git a/public/app/features/dashboard/components/VersionHistory/VersionHistoryTable.tsx b/public/app/features/dashboard/components/VersionHistory/VersionHistoryTable.tsx index b1809b4502e..61f4c34878d 100644 --- a/public/app/features/dashboard/components/VersionHistory/VersionHistoryTable.tsx +++ b/public/app/features/dashboard/components/VersionHistory/VersionHistoryTable.tsx @@ -9,9 +9,11 @@ import { RevertDashboardModal } from './RevertDashboardModal'; type VersionsTableProps = { versions: DecoratedRevisionModel[]; + canCompare: boolean; onCheck: (ev: React.FormEvent, versionId: number) => void; }; -export const VersionHistoryTable: React.FC = ({ versions, onCheck }) => ( + +export const VersionHistoryTable = ({ versions, canCompare, onCheck }: VersionsTableProps) => ( @@ -34,6 +36,7 @@ export const VersionHistoryTable: React.FC = ({ versions, on `} checked={version.checked} onChange={(ev) => onCheck(ev, version.id)} + disabled={!version.checked && canCompare} />
{version.version}