UserSync: Avoid UpdateLastSeenAt with invalid user ids (#72776)

* avoid user zero

* more errors

* more tests

* split
This commit is contained in:
Ryan McKinley
2023-08-03 08:26:02 +02:00
committed by GitHub
parent 1b93f3c0ab
commit 7431c0ddb1
4 changed files with 29 additions and 3 deletions
+5
View File
@@ -368,6 +368,9 @@ func (ss *sqlStore) ChangePassword(ctx context.Context, cmd *user.ChangeUserPass
}
func (ss *sqlStore) UpdateLastSeenAt(ctx context.Context, cmd *user.UpdateUserLastSeenAtCommand) error {
if cmd.UserID <= 0 {
return user.ErrUpdateInvalidID
}
return ss.db.WithTransactionalDbSession(ctx, func(sess *db.Session) error {
user := user.User{
ID: cmd.UserID,
@@ -421,6 +424,8 @@ func (ss *sqlStore) GetSignedInUser(ctx context.Context, query *user.GetSignedIn
} else {
sess.SQL(rawSQL+"WHERE u.email=?", query.Email)
}
default:
return user.ErrNoUniqueID
}
has, err := sess.Get(&signedInUser)
if err != nil {