DashboardSchema: Remove old unused legacy props style and timepicker.enable (#73879)

* DashboardScheam: Remove old unused legacy props style and timepicker.enable

* Update

* fix test

pkg/kinds/dashboard/dashboard_spec_gen.go

@@ -97,12 +97,6 @@ const (
 	RowPanelTypeRow RowPanelType = "row"
 )
 
-// Defines values for SpecStyle.
-const (
-	SpecStyleDark  SpecStyle = "dark"
-	SpecStyleLight SpecStyle = "light"
-)
-
 // Defines values for SpecialValueMapType.
 const (
 	SpecialValueMapTypeRange   SpecialValueMapType = "range"
@@ -771,10 +765,6 @@ type Spec struct {
 	// Sensitive information stripped: queries (metric, template,annotation) and panel links.
 	Snapshot *Snapshot `json:"snapshot,omitempty"`
 
-	// Theme of dashboard.
-	// Default value: dark.
-	Style SpecStyle `json:"style"`
-
 	// Tags associated with dashboard.
 	Tags []string `json:"tags,omitempty"`
 
@@ -796,9 +786,6 @@ type Spec struct {
 		// Whether timepicker is collapsed or not. Has no effect on provisioned dashboard.
 		Collapse bool `json:"collapse"`
 
-		// Whether timepicker is enabled or not. Has no effect on provisioned dashboard.
-		Enable bool `json:"enable"`
-
 		// Whether timepicker is visible or not.
 		Hidden bool `json:"hidden"`
 
@@ -825,10 +812,6 @@ type Spec struct {
 	WeekStart *string `json:"weekStart,omitempty"`
 }
 
-// Theme of dashboard.
-// Default value: dark.
-type SpecStyle string
-
 // Maps special values like Null, NaN (not a number), and boolean values like true and false to a display text and color.
 // See SpecialValueMatch to see the list of special values.
 // For example, you can configure a special value mapping so that null values appear as N/A.

pkg/services/alerting/testdata/collapsed-panels.json

@@ -556,7 +556,6 @@
     }
   ],
   "schemaVersion": 16,
-  "style": "dark",
   "tags": [],
   "templating": {
     "list": []

pkg/services/alerting/testdata/dash-without-id.json

@@ -3,8 +3,7 @@
     "tags": [
       "apa"
     ],
-    "style": "dark",
-    "timezone": "browser",
+      "timezone": "browser",
     "editable": true,
     "sharedCrosshair": false,
     "rows": [

pkg/services/alerting/testdata/influxdb-alert.json

@@ -4,8 +4,7 @@
     "tags": [
       "apa"
     ],
-    "style": "dark",
-    "timezone": "browser",
+      "timezone": "browser",
     "editable": true,
     "sharedCrosshair": false,
     "rows": [

pkg/services/alerting/testdata/panel-with-bad-query-id.json

@@ -168,7 +168,6 @@
     }
   ],
   "schemaVersion": 27,
-  "style": "dark",
   "tags": [],
   "templating": {
     "list": []

pkg/services/alerting/testdata/panel-without-specified-datasource.json

@@ -168,7 +168,6 @@
     }
   ],
   "schemaVersion": 27,
-  "style": "dark",
   "tags": [],
   "templating": {
     "list": []

pkg/services/dashboardimport/service/testdata/dashboard.json

@@ -199,7 +199,6 @@
   "refresh": "1m",
   "revision": "1.0",
   "schemaVersion": 30,
-  "style": "dark",
   "tags": ["prometheus"],
   "templating": {
     "list": []

pkg/services/provisioning/dashboards/testdata/test-dashboards/containing-id/dashboard1.json

@@ -2,8 +2,7 @@
     "title": "Grafana1",
     "tags": [],
     "id": 3,
-    "style": "dark",
-    "timezone": "browser",
+      "timezone": "browser",
     "editable": true,
     "rows": [
       {

pkg/services/provisioning/dashboards/testdata/test-dashboards/dashboard-with-uid/dashboard1.json

@@ -1,8 +1,7 @@
 {
     "title": "Grafana",
     "tags": [],
-    "style": "dark",
-    "timezone": "browser",
+      "timezone": "browser",
     "editable": true,
     "rows": [
       {

pkg/services/provisioning/dashboards/testdata/test-dashboards/folder-one/dashboard1.json

@@ -1,8 +1,7 @@
 {
     "title": "Grafana1",
     "tags": [],
-    "style": "dark",
-    "timezone": "browser",
+      "timezone": "browser",
     "editable": true,
     "rows": [
       {

pkg/services/provisioning/dashboards/testdata/test-dashboards/folder-one/dashboard2.json

@@ -1,8 +1,7 @@
 {
     "title": "Grafana2",
     "tags": [],
-    "style": "dark",
-    "timezone": "browser",
+      "timezone": "browser",
     "editable": true,
     "rows": [
       {

pkg/services/provisioning/dashboards/testdata/test-dashboards/folders-from-files-structure/folderOne/dashboard1.json

@@ -1,8 +1,7 @@
 {
     "title": "Grafana1",
     "tags": [],
-    "style": "dark",
-    "timezone": "browser",
+      "timezone": "browser",
     "editable": true,
     "rows": [
       {

pkg/services/provisioning/dashboards/testdata/test-dashboards/folders-from-files-structure/folderTwo/dashboard2.json

@@ -1,8 +1,7 @@
 {
     "title": "Grafana2",
     "tags": [],
-    "style": "dark",
-    "timezone": "browser",
+      "timezone": "browser",
     "editable": true,
     "rows": [
       {

pkg/services/provisioning/dashboards/testdata/test-dashboards/folders-from-files-structure/root.json

@@ -1,8 +1,7 @@
 {
     "title": "RootDashboard",
     "tags": [],
-    "style": "dark",
-    "timezone": "browser",
+      "timezone": "browser",
     "editable": true,
     "rows": [
       {

pkg/services/provisioning/dashboards/testdata/test-dashboards/one-dashboard/dashboard1.json

@@ -1,8 +1,7 @@
 {
     "title": "Grafana",
     "tags": [],
-    "style": "dark",
-    "timezone": "browser",
+      "timezone": "browser",
     "editable": true,
     "rows": [
       {
@@ -170,4 +169,3 @@
     },
     "version": 5
   }
-  

pkg/services/provisioning/dashboards/testdata/test-dashboards/two-dashboards-with-uid/dashboard1.json

@@ -1,8 +1,7 @@
 {
     "title": "Grafana",
     "tags": [],
-    "style": "dark",
-    "timezone": "browser",
+      "timezone": "browser",
     "editable": true,
     "rows": [
       {

pkg/services/provisioning/dashboards/testdata/test-dashboards/two-dashboards-with-uid/dashboard2.json

@@ -1,8 +1,7 @@
 {
     "title": "Grafana",
     "tags": [],
-    "style": "dark",
-    "timezone": "browser",
+      "timezone": "browser",
     "editable": true,
     "rows": [
       {

pkg/services/provisioning/dashboards/testdata/test-dashboards/unprovision/dashboard1.json

@@ -1,8 +1,7 @@
 {
     "title": "Grafana1",
     "tags": [],
-    "style": "dark",
-    "timezone": "browser",
+      "timezone": "browser",
     "editable": true,
     "rows": [
       {

pkg/services/store/entity/tests/testdata/dashboard-with-tags-b-g.json

@@ -23,7 +23,6 @@
     }
   ],
   "schemaVersion": 36,
-  "style": "dark",
   "templating": {
     "list": []
   },

pkg/services/store/entity/tests/testdata/dashboard-with-tags-r-g.json

@@ -23,7 +23,6 @@
     }
   ],
   "schemaVersion": 36,
-  "style": "dark",
   "templating": {
     "list": []
   },

pkg/services/store/kind/dashboard/testdata/all-selected-multi-datasource-variable.json

@@ -188,7 +188,6 @@
     }
   ],
   "schemaVersion": 36,
-  "style": "dark",
   "tags": [],
   "templating": {
     "list": [

pkg/services/store/kind/dashboard/testdata/all-selected-single-datasource-variable.json

@@ -96,7 +96,6 @@
   ],
   "refresh": "",
   "schemaVersion": 36,
-  "style": "dark",
   "tags": [],
   "templating": {
     "list": [

pkg/services/store/kind/dashboard/testdata/check-string-datasource-id.json

@@ -50,8 +50,7 @@
         }
     ],
     "schemaVersion": 27,
-    "style": "dark",
-    "tags": [],
+      "tags": [],
     "templating": {
         "list": []
     },

pkg/services/store/kind/dashboard/testdata/datasource-variable-no-curly-braces.json

@@ -97,7 +97,6 @@
     }
   ],
   "schemaVersion": 36,
-  "style": "dark",
   "tags": [],
   "templating": {
     "list": [

pkg/services/store/kind/dashboard/testdata/datasource-variable.json

@@ -97,7 +97,6 @@
     }
   ],
   "schemaVersion": 36,
-  "style": "dark",
   "tags": [],
   "templating": {
     "list": [

pkg/services/store/kind/dashboard/testdata/default-datasource-variable.json

@@ -96,7 +96,6 @@
   ],
   "refresh": "",
   "schemaVersion": 36,
-  "style": "dark",
   "tags": [],
   "templating": {
     "list": [

pkg/services/store/kind/dashboard/testdata/empty-datasource-variable.json

@@ -97,7 +97,6 @@
     }
   ],
   "schemaVersion": 36,
-  "style": "dark",
   "tags": [],
   "templating": {
     "list": [

pkg/services/store/kind/dashboard/testdata/mixed-datasource-with-variable.json

@@ -96,7 +96,6 @@
   ],
   "refresh": "",
   "schemaVersion": 36,
-  "style": "dark",
   "tags": [],
   "templating": {
     "list": [

pkg/services/store/kind/dashboard/testdata/panels-without-datasources.json

@@ -313,7 +313,6 @@
     }
   ],
   "schemaVersion": 19,
-  "style": "dark",
   "tags": [
     "gdev",
     "datasource-test"

pkg/services/store/kind/dashboard/testdata/repeated-datasource-variables-with-default.json

@@ -96,7 +96,6 @@
   ],
   "refresh": "",
   "schemaVersion": 36,
-  "style": "dark",
   "tags": [],
   "templating": {
     "list": [

pkg/services/store/kind/dashboard/testdata/repeated-datasource-variables.json

@@ -100,7 +100,6 @@
     }
   ],
   "schemaVersion": 36,
-  "style": "dark",
   "tags": [],
   "templating": {
     "list": [

pkg/services/store/kind/dashboard/testdata/special-datasource-types.json

@@ -292,7 +292,6 @@
     }
   ],
   "schemaVersion": 36,
-  "style": "dark",
   "tags": [],
   "templating": {
     "list": []

pkg/services/store/kind/dashboard/testdata/string-datasource-variable.json

@@ -72,7 +72,6 @@
     }
   ],
   "schemaVersion": 36,
-  "style": "dark",
   "tags": [],
   "templating": {
     "list": [

pkg/services/store/kind/dashboard/testdata/with-library-panels.json

@@ -53,8 +53,7 @@
     ],
     "refresh": "",
     "schemaVersion": 38,
-    "style": "dark",
-    "tags": [],
+      "tags": [],
     "templating": {
       "list": []
     },
@@ -69,4 +68,3 @@
     "version": 3,
     "weekStart": ""
   }
-  

pkg/tests/api/dashboards/home.json

@@ -190,7 +190,6 @@
     }
   ],
   "schemaVersion": 30,
-  "style": "dark",
   "tags": [],
   "templating": {
     "list": []