[release-10.4.18] Go: Bump to 1.24.2 (#103531)

* Go: Bump to 1.24.2

* CI: Update golangci-lint

* feat: update swagger

* fix: more lints

* fix: lints

pkg/api/datasources.go

@@ -407,7 +407,7 @@ func validateLBACHeader(headervalue string) bool {
 		return false
 	}
 	match := pattern.FindSubmatch([]byte(strings.TrimSpace(headervalue)))
-	if match == nil || len(match) < 2 {
+	if len(match) < 2 {
 		return false
 	}
 	_, err = parser.ParseMetricSelector(string(match[1]))

pkg/api/frontend_logging.go

@@ -79,7 +79,7 @@ func GrafanaJavascriptAgentLogMessageHandler(store *frontendlogging.SourceMapSto
 			for _, exception := range event.Exceptions {
 				var ctx = frontendlogging.CtxVector{}
 				ctx = event.AddMetaToContext(ctx)
-				exception := exception
+
 				transformedException := frontendlogging.TransformException(c.Req.Context(), &exception, store)
 				ctx = append(ctx, "kind", "exception", "type", transformedException.Type, "value", transformedException.Value, "stacktrace", transformedException.String())
 				ctx = append(ctx, "original_timestamp", exception.Timestamp)

pkg/api/frontendlogging/grafana_javascript_agent_sourcemaps.go

@@ -10,7 +10,6 @@ func TransformException(ctx context.Context, ex *Exception, store *SourceMapStor
 	frames := []Frame{}
 
 	for _, frame := range ex.Stacktrace.Frames {
-		frame := frame
 		mappedFrame, err := store.resolveSourceLocation(ctx, frame)
 		if err != nil {
 			frames = append(frames, frame)

pkg/api/response/response_test.go

@@ -94,7 +94,6 @@ func TestErrors(t *testing.T) {
 	}
 
 	for _, tc := range cases {
-		tc := tc
 		t.Run(
 			tc.name+" Error",
 			compareResponses(tc.legacyResponse, Error(

pkg/api/user.go

@@ -673,6 +673,7 @@ func (hs *HTTPServer) SetHelpFlag(c *contextmodel.ReqContext) response.Response
 	}
 
 	bitmask := &usr.HelpFlags1
+	//nolint:gosec // G115
 	bitmask.AddFlag(user.HelpFlags1(flag))
 
 	cmd := user.SetUserHelpFlagCommand{