From 751eb2c8bb9dae63d42d61ecb2e354df12ca30ac Mon Sep 17 00:00:00 2001 From: Tobias Skarhed <1438972+tskarhed@users.noreply.github.com> Date: Sat, 25 Jan 2020 16:59:58 +0100 Subject: [PATCH] TablePabel: Sanitize column link (#21735) --- public/app/plugins/panel/table/renderer.ts | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/public/app/plugins/panel/table/renderer.ts b/public/app/plugins/panel/table/renderer.ts index 8b9623ba4a9..7f269bd2162 100644 --- a/public/app/plugins/panel/table/renderer.ts +++ b/public/app/plugins/panel/table/renderer.ts @@ -14,6 +14,7 @@ import { import { TemplateSrv } from 'app/features/templating/template_srv'; import { ColumnRender, TableRenderModel, ColumnStyle } from './types'; import { ColumnOptionsCtrl } from './column_options'; +import { sanitizeUrl } from 'app/core/utils/text'; export class TableRenderer { formatters: any[]; @@ -297,13 +298,15 @@ export class TableRenderer { scopedVars['__cell'] = { value: value, text: value ? value.toString() : '' }; const cellLink = this.templateSrv.replace(column.style.linkUrl, scopedVars, encodeURIComponent); + const sanitizedCellLink = sanitizeUrl(cellLink); + const cellLinkTooltip = this.templateSrv.replace(column.style.linkTooltip, scopedVars); const cellTarget = column.style.linkTargetBlank ? '_blank' : ''; cellClasses.push('table-panel-cell-link'); columnHtml += ` - + ${value} `;